[HOLD for payment 2023-06-15] [$250] Migrate AddressPage.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/settings/Profile/PersonalDetails/AddressPage.js
  • type: React.Component
  • has state values: true
  • has refs: false
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0196d43197753c4c34
• Upwork Job ID: 1665802136107708416
• Last Price Increase: 2023-06-05

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[marcaaron]

Heads up, I'm taking this issue off HOLD and making it a Daily. If you are unable to work on it please remove your assignment and add the External + Help Wanted labels as per this update.

[LukaRusadze]

I'll gladly work on this

[multijump]

I would like to take this issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0196d43197753c4c34

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[muxriddinmuqimov77]

I'd like to work on this issue

[aldo-expensify]

Swapping C+ assignment because @0xmiroslav is already reviewing

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate AddressPage to functional component #20089

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[aldo-expensify]

@jliexpensify , this is a code refactor issue, and you only have to handle the payment to the C+ (@0xmiroslav ) for reviewing the PR #20089

[jliexpensify]

Invited @0xmiroslav

[aldo-expensify]

Ping @0xmiroslav

[0xmiros]

Accepted invite already

[aldo-expensify]

oh, Ping @jliexpensify then :P

[jliexpensify]

Sorry sorry, had it on my to-do list but the fire yesterday took up my afternoon. Paying now!

[jliexpensify]

@0xmiroslav have hired you, once accepted I'll pay the $250, cheers!

[jliexpensify]

Paid and closed job!