[HOLD for payment 2023-02-14] [HOLD for payment 2023-02-13] Web - New Group/IOU - Arrow key navigation stopped working

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Click +
3. Click Request money
4. Choose amount an click Next
5. Press Arrow keys to navigate through attendees list

or

1. Go to https://staging.new.expensify.com/
2. Go to group chat
3. Click +
4. Click Split bill
5. Choose amount an click Next
6. Press Arrow keys to navigate through attendees list

Expected Result:

Focus should be from one account to another

Actual Result:

The whole list moves instead of focus. Or just nothing happens.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.65.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5925100_video_07.mp4

Bug5925100_video_06.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

Unlocked the conversation I have confirmed this is actual deploy blocker

[situchan]

I confirmed that #14794 caused this regression.

[mountiny]

Oh really? We assumed that was missed as that was the only missing condition to revert

[situchan]

@mountiny actually, that's a good fix. The main root cause is that OptionRow is not updated whenever arrow key pressed so hover background color not changing even though selected actually. So it's visual issue.
I have solution

[situchan]

+           || this.props.optionIsFocused !== nextProps.optionIsFocused

Let's add this in shouldComponentUpdate condition

[mountiny]

I will revert the change and we can elaborte on this new option more, we need to fix this sooner so it does not block deploy and this code is super prone to some bugs as it touches a lot of parts of the code so I would refrain from adding another condition.

Can you write down an official bug? what is broken without the condition you have mentioned?

[situchan]

@mountiny I think no need to revert because below condition is always true and OptionRow is updated every time any props changes so it causes performance issue which was the purpose of that PR.

            || _.isEqual(this.props.option.icons, nextProps.option.icons)

[situchan]

Can you write down an official bug? what is broken without the condition you have mentioned?

The official bug is that optionIsFocused props change was missing in shouldComponentUpdate.
|| _.isEqual(this.props.option.icons, nextProps.option.icons) this line was a mistake and also has hidden bug above.

[mountiny]

Let me have a look @situchan you are right about the condition

[mountiny]

I see forgot to add it once it was removed here https://github.com/Expensify/App/pull/14791/files#diff-2584464930cd870e953ab50a7dbe0dac4b9d9f6c2818f61fb1dc06e3828dd897L89

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

@situchan Thank you for help, I have assigned @garrettmknight to help with paying out $250 for helping here!

[garrettmknight]

@situchan offer sent - accept and I'll pay!

[situchan]

Accepted offer. Thank you @mountiny @garrettmknight

[garrettmknight]

Paid, link for reference. Unassigning myself.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.65-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Check whether option row changed focus before re-rendering #14856

If no regressions arise, payment will be issued on 2023-02-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mountiny] Propose regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

No need for these

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.66-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Check whether option row changed focus before re-rendering #14856

If no regressions arise, payment will be issued on 2023-02-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mountiny] Propose regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[situchan]

@garrettmknight I haven't got payment yet. You just hired me, and not released milestone.

[MelvinBot]

📣 @situchan! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[garrettmknight]

Hey @situchan, sorry about that. Just paid.

[situchan]

@garrettmknight Thanks so much. You can also close contract.