Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement our headline font Expensify New Kansas #13686

Closed
shawnborton opened this issue Dec 19, 2022 · 15 comments
Closed

Implement our headline font Expensify New Kansas #13686

shawnborton opened this issue Dec 19, 2022 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Design Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@shawnborton
Copy link
Contributor

shawnborton commented Dec 19, 2022

We finally have font files for New Kansas, woo! So now let's implement it.

For now, I believe the only weight we use in our brand will be "Medium" and "Medium Italic." I've packaged up both of those in .otf and .woff/.woff2 format here: ExpensifyNewKansas.zip

In terms of implementation, there are a few areas where we'll want to begin with this:

The Chats header in the top left:
image

Workspace editor card titles:
image

Name in Settings:
image

Big Number Pad:
image

And the in places like the full screen empty state, as well as some "Success" moments like when you add a bank account, etc (I am having a hard time digging up those screenies though!)

cc @grgia @Luke9389 @roryabraham in case any of you want to take this one for implementation. This is one of the last bits of implementing our core brand.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0129e2192610c499ad
  • Upwork Job ID: 1618076125316882432
  • Last Price Increase: 2023-01-25
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Dec 19, 2022
@shawnborton shawnborton self-assigned this Dec 19, 2022
@luacmartins
Copy link
Contributor

I can work on this!

@luacmartins luacmartins self-assigned this Dec 19, 2022
@luacmartins luacmartins added the Daily KSv2 label Dec 19, 2022
@Luke9389
Copy link
Contributor

Woohoo! So stoked to see this in action!

@Luke9389
Copy link
Contributor

@luacmartins adding new fonts comes along with a few 'gotcha's, so let me know if you run into anything funky.

@shawnborton
Copy link
Contributor Author

Woo, thanks Carlos!

@luacmartins
Copy link
Contributor

Thanks @Luke9389! I'll let you know if I have any questions!

@shawnborton could you please confirm the following:

  1. Chats - the LHN header shares the same styles with our HeaderWithCloseButton component, i.e. the type of headers seen below. Do we want to update all instances of HeaderWithCloseButton as well or just the one in the LHN?

Screenshot 2022-12-19 at 5 16 56 PM

  1. Name in Settings - currently, this page shares the same styles with the pages below. Do we want to update all instances or just the one in InitialSettingsPage?

    • DetailsPage - when you click at the chat header and see someone's details
    • WorkspaceIntialPage - Workspace name in the Workspace initial page
  2. Full screen empty state - I'm not sure which page this is. Do you have a mock of the page so I can try to locate it in App?

  3. Some "Success" moments - Right now the pages below share the same style with Workspace editor card titles. Do we want to update all of them? Are there other "success" moments that should be updated?

    • BankAccount > EnableStep
    • RequestCallPage
    • GetAssistancePage

@shawnborton
Copy link
Contributor Author

  1. For this one, I think we only want this on the LHN for now.
  2. I like using this again in DetailsPage as well as WorkspaceInitialPage.
  3. It looks something like this: image
  4. In these success moments, they kind of look like the screen above however they have a generic "tada" image. Actually maybe if you search the code for tada.svg it will lead you to the right place? For these, we just want the headline immediately under the tada image to use the headline font. Similarly, there is a screen we use when we review account details. I think you can find examples of them here actually.

@luacmartins luacmartins mentioned this issue Dec 20, 2022
53 tasks
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Dec 20, 2022
@luacmartins
Copy link
Contributor

PR here

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 10, 2023
@luacmartins
Copy link
Contributor

The PR has been on prod for 2 weeks. Adding the Bug label to get a BZ assigned and process payment!

@luacmartins luacmartins added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 25, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 25, 2023
@luacmartins luacmartins added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Daily KSv2 labels Jan 25, 2023
@melvin-bot melvin-bot bot unlocked this conversation Jan 25, 2023
@melvin-bot melvin-bot bot unlocked this conversation Jan 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 25, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0129e2192610c499ad

@melvin-bot
Copy link

melvin-bot bot commented Jan 25, 2023

Current assignee @parasharrajat is eligible for the Internal assigner, not assigning anyone new.

@luacmartins
Copy link
Contributor

@alexpensify could you help pay @parasharrajat for the review in this PR? The regression period is over since that PR hit prod 2 weeks ago.

@alexpensify
Copy link
Contributor

@parasharrajat - I've submitted an offer via Upwork. Please confirm you received it and I can close out this GH. Thanks!

@alexpensify
Copy link
Contributor

@parasharrajat - checking in, I see the offer is still pending in Upwork. When you get a chance, can you please confirm you received it? Thanks!

@parasharrajat
Copy link
Member

@alexpensify Accepted it.

@alexpensify
Copy link
Contributor

Thanks! I've completed the payment process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Design Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants