Skip to content

Commit f869d0c

Browse files
ShridharGoelShridharGoel
committed
Update
1 parent 1cd7170 commit f869d0c

15 files changed

+26
-28
lines changed

‎package-lock.json

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@
259259
"electron-builder": "24.13.2",
260260
"eslint": "^7.6.0",
261261
"eslint-config-airbnb-typescript": "^17.1.0",
262-
"eslint-config-expensify": "^2.0.47",
262+
"eslint-config-expensify": "^2.0.50",
263263
"eslint-config-prettier": "^8.8.0",
264264
"eslint-plugin-import": "^2.29.1",
265265
"eslint-plugin-jest": "^24.1.0",

‎src/components/ReportActionItem/MoneyReportView.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ function MoneyReportView({report, policy}: MoneyReportViewProps) {
4343
const formattedTotalAmount = CurrencyUtils.convertToDisplayString(totalDisplaySpend, report.currency);
4444
const formattedOutOfPocketAmount = CurrencyUtils.convertToDisplayString(reimbursableSpend, report.currency);
4545
const formattedCompanySpendAmount = CurrencyUtils.convertToDisplayString(nonReimbursableSpend, report.currency);
46-
const isPartiallyPaid = Boolean(report?.pendingFields?.partial);
46+
const isPartiallyPaid = !!report?.pendingFields?.partial;
4747

4848
const subAmountTextStyles: StyleProp<TextStyle> = [
4949
styles.taskTitleMenuItem,
@@ -121,7 +121,7 @@ function MoneyReportView({report, policy}: MoneyReportViewProps) {
121121
</Text>
122122
</View>
123123
</View>
124-
{Boolean(shouldShowBreakdown) && (
124+
{!!shouldShowBreakdown && (
125125
<>
126126
<View style={[styles.flexRow, styles.pointerEventsNone, styles.containerWithSpaceBetween, styles.ph5, styles.pv1]}>
127127
<View style={[styles.flex1, styles.justifyContentCenter]}>

‎src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

+1-3
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,7 @@ function MoneyRequestPreviewContent({
9393
const isSettlementOrApprovalPartial = !!iouReport?.pendingFields?.partial;
9494
const isPartialHold = isSettlementOrApprovalPartial && isOnHold;
9595
const hasViolations = TransactionUtils.hasViolation(transaction?.transactionID ?? '', transactionViolations);
96-
const hasNoticeTypeViolations = Boolean(
97-
TransactionUtils.hasNoticeTypeViolation(transaction?.transactionID ?? '', transactionViolations) && ReportUtils.isPaidGroupPolicy(iouReport) && canUseViolations,
98-
);
96+
const hasNoticeTypeViolations = !!(TransactionUtils.hasNoticeTypeViolation(transaction?.transactionID ?? '', transactionViolations) && ReportUtils.isPaidGroupPolicy(iouReport) && canUseViolations);
9997
const hasFieldErrors = TransactionUtils.hasMissingSmartscanFields(transaction);
10098
const isDistanceRequest = TransactionUtils.isDistanceRequest(transaction);
10199
const isFetchingWaypointsFromServer = TransactionUtils.isFetchingWaypointsFromServer(transaction);

‎src/components/ReportActionItem/MoneyRequestView.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ function MoneyRequestView({
119119
const isEmptyMerchant = transactionMerchant === '' || transactionMerchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT;
120120
const isDistanceRequest = TransactionUtils.isDistanceRequest(transaction);
121121
const formattedTransactionAmount = transactionAmount ? CurrencyUtils.convertToDisplayString(transactionAmount, transactionCurrency) : '';
122-
const hasPendingWaypoints = Boolean(transaction?.pendingFields?.waypoints);
122+
const hasPendingWaypoints = !!transaction?.pendingFields?.waypoints;
123123
const showMapAsImage = isDistanceRequest && hasPendingWaypoints;
124124
const formattedOriginalAmount = transactionOriginalAmount && transactionOriginalCurrency && CurrencyUtils.convertToDisplayString(transactionOriginalAmount, transactionOriginalCurrency);
125125
const isCardTransaction = TransactionUtils.isCardTransaction(transaction);
@@ -338,7 +338,7 @@ function MoneyRequestView({
338338
{shouldShowReceiptHeader && (
339339
<ReceiptAuditHeader
340340
notes={receiptViolations}
341-
shouldShowAuditMessage={Boolean(shouldShowNotesViolations && didRceiptScanSucceed)}
341+
shouldShowAuditMessage={!!(shouldShowNotesViolations && didRceiptScanSucceed)}
342342
/>
343343
)}
344344
{shouldShowMapOrReceipt && (

‎src/components/Switch.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ function Switch({isOn, onToggle, accessibilityLabel, disabled, showLockIcon}: Sw
6363
pressDimmingValue={0.8}
6464
>
6565
<Animated.View style={[styles.switchThumb, styles.switchThumbTransformation(offsetX.current)]}>
66-
{(Boolean(disabled) || Boolean(showLockIcon)) && (
66+
{(!!disabled || !!showLockIcon) && (
6767
<Icon
6868
src={Expensicons.Lock}
6969
fill={isOn ? theme.text : theme.icon}

‎src/libs/HttpUtils.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ Onyx.connect({
2727
if (!network) {
2828
return;
2929
}
30-
shouldFailAllRequests = Boolean(network.shouldFailAllRequests);
31-
shouldForceOffline = Boolean(network.shouldForceOffline);
30+
shouldFailAllRequests = !!(network.shouldFailAllRequests);
31+
shouldForceOffline = !!(network.shouldForceOffline);
3232
},
3333
});
3434

‎src/libs/Navigation/linkTo/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export default function linkTo(navigation: NavigationContainerRef<RootStackParam
7171
const topRouteName = rootState?.routes?.at(-1)?.name;
7272
const isTargetNavigatorOnTop = topRouteName === action.payload.name;
7373

74-
const isTargetScreenDifferentThanCurrent = Boolean(!topmostCentralPaneRoute || topmostCentralPaneRoute.name !== action.payload.params?.screen);
74+
const isTargetScreenDifferentThanCurrent = !!(!topmostCentralPaneRoute || topmostCentralPaneRoute.name !== action.payload.params?.screen);
7575
const areParamsDifferent =
7676
action.payload.params?.screen === SCREENS.REPORT
7777
? getTopmostReportId(rootState) !== getTopmostReportId(stateFromPath)

‎src/libs/PolicyUtils.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ function getPolicyBrickRoadIndicatorStatus(policy: OnyxEntry<Policy>): ValueOf<t
117117
function shouldShowPolicy(policy: OnyxEntry<Policy>, isOffline: boolean): boolean {
118118
return (
119119
!!policy &&
120-
(policy?.isPolicyExpenseChatEnabled || Boolean(policy?.isJoinRequestPending)) &&
120+
(policy?.isPolicyExpenseChatEnabled || !!policy?.isJoinRequestPending) &&
121121
(isOffline || policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || Object.keys(policy.errors ?? {}).length > 0)
122122
);
123123
}
@@ -336,10 +336,10 @@ function canEditTaxRate(policy: Policy, taxID: string): boolean {
336336

337337
function isPolicyFeatureEnabled(policy: OnyxEntry<Policy> | EmptyObject, featureName: PolicyFeatureName): boolean {
338338
if (featureName === CONST.POLICY.MORE_FEATURES.ARE_TAXES_ENABLED) {
339-
return Boolean(policy?.tax?.trackingEnabled);
339+
return !!policy?.tax?.trackingEnabled;
340340
}
341341

342-
return Boolean(policy?.[featureName]);
342+
return !!policy?.[featureName];
343343
}
344344

345345
function getApprovalWorkflow(policy: OnyxEntry<Policy> | EmptyObject): ValueOf<typeof CONST.POLICY.APPROVAL_MODE> {

‎src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ function BaseOnboardingPurpose({shouldUseNativeStyles, shouldEnableMaxHeight, on
154154
saveAndNavigate();
155155
}}
156156
message={errorMessage}
157-
isAlertVisible={Boolean(errorMessage)}
157+
isAlertVisible={!!errorMessage}
158158
containerStyles={[styles.w100, styles.mb5, styles.mh0, paddingHorizontal]}
159159
/>
160160
</View>

‎src/pages/ProfilePage.tsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ function ProfilePage({route}: ProfilePageProps) {
8181
const accountID = Number(route.params?.accountID ?? 0);
8282
const reportID = ReportUtils.getChatByParticipants(session?.accountID ? [accountID, session.accountID] : [], reports)?.reportID ?? '';
8383

84-
if ((Boolean(session) && Number(session?.accountID) === accountID) || SessionActions.isAnonymousUser() || !reportID) {
84+
if ((!!session && Number(session?.accountID) === accountID) || SessionActions.isAnonymousUser() || !reportID) {
8585
return `${ONYXKEYS.COLLECTION.REPORT}0` as const;
8686
}
8787
return `${ONYXKEYS.COLLECTION.REPORT}${reportID}` as const;
@@ -114,8 +114,8 @@ function ProfilePage({route}: ProfilePageProps) {
114114
const phoneNumber = getPhoneNumber(details);
115115
const phoneOrEmail = isSMSLogin ? getPhoneNumber(details) : login;
116116

117-
const hasAvatar = Boolean(details.avatar);
118-
const isLoading = Boolean(personalDetailsMetadata?.[accountID]?.isLoading) || isEmptyObject(details);
117+
const hasAvatar = !!details.avatar;
118+
const isLoading = !!personalDetailsMetadata?.[accountID]?.isLoading || isEmptyObject(details);
119119

120120
const statusEmojiCode = details?.status?.emojiCode ?? '';
121121
const statusText = details?.status?.text ?? '';
@@ -165,7 +165,7 @@ function ProfilePage({route}: ProfilePageProps) {
165165
/>
166166
</OfflineWithFeedback>
167167
</PressableWithoutFocus>
168-
{Boolean(displayName) && (
168+
{!!displayName && (
169169
<Text
170170
style={[styles.textHeadline, styles.pre, styles.mb6, styles.w100, styles.textAlignCenter]}
171171
numberOfLines={1}

‎src/pages/iou/request/step/withWritableReportOrNotFound.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export default function <TProps extends WithWritableReportOrNotFoundProps<MoneyR
6262
const canUserPerformWriteAction = ReportUtils.canUserPerformWriteAction(report);
6363

6464
useEffect(() => {
65-
if (Boolean(report?.reportID) || !route.params.reportID) {
65+
if (!!report?.reportID || !route.params.reportID) {
6666
return;
6767
}
6868

‎src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ function WorkspaceCategoriesPage({route}: WorkspaceCategoriesPageProps) {
5858
const [policy] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${policyId}`);
5959
const [policyCategories] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyId}`);
6060
const isConnectedToAccounting = Object.keys(policy?.connections ?? {}).length > 0;
61-
const isConnectedToQbo = Boolean(policy?.connections?.quickbooksOnline);
61+
const isConnectedToQbo = !!policy?.connections?.quickbooksOnline;
6262

6363
const fetchCategories = useCallback(() => {
6464
Category.openPolicyCategoriesPage(policyId);

‎src/pages/workspace/tags/WorkspaceTagsPage.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function WorkspaceTagsPage({route}: WorkspaceTagsPageProps) {
5252
const [policyTags] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`);
5353
const {environmentURL} = useEnvironment();
5454
const isConnectedToAccounting = Object.keys(policy?.connections ?? {}).length > 0;
55-
const isConnectedToQbo = Boolean(policy?.connections?.quickbooksOnline);
55+
const isConnectedToQbo = !!policy?.connections?.quickbooksOnline;
5656
const [policyTagLists, isMultiLevelTags] = useMemo(() => [PolicyUtils.getTagLists(policyTags), PolicyUtils.isMultiLevelTags(policyTags)], [policyTags]);
5757
const canSelectMultiple = !isMultiLevelTags;
5858

‎src/pages/workspace/taxes/WorkspaceTaxesPage.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ function WorkspaceTaxesPage({
5858
const hasAccountingConnections = PolicyUtils.hasAccountingConnections(policy);
5959

6060
const isConnectedToAccounting = Object.keys(policy?.connections ?? {}).length > 0;
61-
const isConnectedToQbo = Boolean(policy?.connections?.quickbooksOnline);
61+
const isConnectedToQbo = !!policy?.connections?.quickbooksOnline;
6262

6363
const fetchTaxes = useCallback(() => {
6464
openPolicyTaxesPage(policyID);

0 commit comments

Comments
 (0)