Skip to content

Commit f4e7e2a

Browse files
Add Viewport to addResizeListener name for clarity
1 parent f56ea8d commit f4e7e2a

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/libs/VisualViewport/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* @param {Function} onViewportResize
55
* @returns {Function}
66
*/
7-
function addResizeListener(onViewportResize) {
7+
function addViewportResizeListener(onViewportResize) {
88
if (!window.visualViewport) {
99
return () => {};
1010
}
@@ -13,4 +13,4 @@ function addResizeListener(onViewportResize) {
1313
return () => window.visualViewport.removeEventListener('resize', onViewportResize);
1414
}
1515

16-
export default addResizeListener;
16+
export default addViewportResizeListener;

src/libs/VisualViewport/index.native.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
* @returns {Function}
77
*/
88
// eslint-disable-next-line no-unused-vars
9-
function addResizeListener(onViewportResize) {
9+
function addViewportResizeListener(onViewportResize) {
1010
return () => {};
1111
}
1212

13-
export default addResizeListener;
13+
export default addViewportResizeListener;

src/pages/home/ReportScreen.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import ReportActionsSkeletonView from '../../components/ReportActionsSkeletonVie
2323
import reportActionPropTypes from './report/reportActionPropTypes';
2424
import ArchivedReportFooter from '../../components/ArchivedReportFooter';
2525
import toggleReportActionComposeView from '../../libs/toggleReportActionComposeView';
26-
import addResizeListener from '../../libs/VisualViewport';
26+
import addViewportResizeListener from '../../libs/VisualViewport';
2727

2828
const propTypes = {
2929
/** Navigation route context info provided by react navigation */
@@ -115,7 +115,7 @@ class ReportScreen extends React.Component {
115115

116116
this.onSubmitComment = this.onSubmitComment.bind(this);
117117
this.viewportOffsetTop = this.updateViewportOffsetTop.bind(this);
118-
this.removeResizeListener = () => {};
118+
this.removeViewportResizeListener = () => {};
119119

120120
this.state = {
121121
skeletonViewContainerHeight: 0,
@@ -125,7 +125,7 @@ class ReportScreen extends React.Component {
125125

126126
componentDidMount() {
127127
this.storeCurrentlyViewedReport();
128-
this.removeResizeListener = addResizeListener(this.viewportOffsetTop);
128+
this.removeViewportResizeListener = addViewportResizeListener(this.viewportOffsetTop);
129129
}
130130

131131
componentDidUpdate(prevProps) {
@@ -137,7 +137,7 @@ class ReportScreen extends React.Component {
137137

138138
componentWillUnmount() {
139139
clearTimeout(this.loadingTimerId);
140-
this.removeResizeListener();
140+
this.removeViewportResizeListener();
141141
}
142142

143143
/**

0 commit comments

Comments
 (0)