Use ISO timestamp

Author: yuwenmemon

src/CONST.ts

@@ -1806,7 +1806,7 @@ const CONST = {
                 XERO_CHECK_CONNECTION: 'xeroCheckConnection',
                 XERO_SYNC_TITLE: 'xeroSyncTitle',
             },
-            SYNC_STAGE_TIMEOUT: 1_200_000, // 20 minutes (20m * 60s * 1000ms)
+            SYNC_STAGE_TIMEOUT_MINUTES: 20,
         },
         ACCESS_VARIANTS: {
             PAID: 'paid',

src/libs/actions/connections/QuickBooksOnline.ts

@@ -21,7 +21,7 @@ function syncConnection(policyID: string) {
             value: {
                 stageInProgress: CONST.POLICY.CONNECTIONS.SYNC_STAGE_NAME.STARTING_IMPORT,
                 connectionName: CONST.POLICY.CONNECTIONS.NAME.QBO,
-                timestamp: Date.now(),
+                timestamp: new Date().toISOString(),
             },
         },
     ];

src/pages/workspace/accounting/PolicyAccountingPage.tsx

@@ -39,6 +39,7 @@ import type {Policy, PolicyConnectionSyncProgress} from '@src/types/onyx';
 import type {PolicyConnectionName} from '@src/types/onyx/Policy';
 import {isEmptyObject} from '@src/types/utils/EmptyObject';
 import type IconAsset from '@src/types/utils/IconAsset';
+import {differenceInMinutes, parseISO, isValid} from "date-fns";
 
 type PolicyAccountingPageOnyxProps = {
     connectionSyncProgress: OnyxEntry<PolicyConnectionSyncProgress>;
@@ -112,10 +113,11 @@ function PolicyAccountingPage({policy, connectionSyncProgress, isConnectionDataF
     const [isDisconnectModalOpen, setIsDisconnectModalOpen] = useState(false);
     const threeDotsMenuContainerRef = useRef<View>(null);
 
+    const lastSyncProgressDate = parseISO(connectionSyncProgress?.timestamp ?? '');
     const isSyncInProgress =
         !!connectionSyncProgress?.stageInProgress &&
         connectionSyncProgress.stageInProgress !== CONST.POLICY.CONNECTIONS.SYNC_STAGE_NAME.JOB_DONE &&
-        Date.now() - (connectionSyncProgress.timestamp ?? 0) < CONST.POLICY.CONNECTIONS.SYNC_STAGE_TIMEOUT;
+        (isValid(lastSyncProgressDate) && differenceInMinutes(new Date(), lastSyncProgressDate) < CONST.POLICY.CONNECTIONS.SYNC_STAGE_TIMEOUT_MINUTES);
 
     const accountingIntegrations = Object.values(CONST.POLICY.CONNECTIONS.NAME).filter((name) => !(name === CONST.POLICY.CONNECTIONS.NAME.XERO && !canUseXeroIntegration));
     const connectedIntegration = accountingIntegrations.find((integration) => !!policy?.connections?.[integration]) ?? connectionSyncProgress?.connectionName;

src/types/onyx/Policy.ts

@@ -545,7 +545,7 @@ type PolicyConnectionName = ValueOf<typeof CONST.POLICY.CONNECTIONS.NAME>;
 type PolicyConnectionSyncProgress = {
     stageInProgress: PolicyConnectionSyncStage;
     connectionName: PolicyConnectionName;
-    timestamp: number;
+    timestamp: string;
 };
 
 export default Policy;