Merge pull request #56987 from Expensify/yuwen-nsqsFixes

Add defaults for missing NSQS values

Author: grgia

src/pages/workspace/accounting/nsqs/advanced/NSQSAdvancedPage.tsx

@@ -22,7 +22,7 @@ function NSQSAdvancedPage({policy}: WithPolicyProps) {
     const styles = useThemeStyles();
     const policyID = policy?.id;
     const nsqsConfig = policy?.connections?.netsuiteQuickStart?.config;
-    const isAutoSyncEnabled = nsqsConfig?.autoSync.enabled ?? false;
+    const isAutoSyncEnabled = nsqsConfig?.autoSync?.enabled ?? false;
     const approvalAccount = nsqsConfig?.approvalAccount ?? '';
     const nsqsData = policy?.connections?.netsuiteQuickStart?.data;
     const payableAccounts: NSQSPayableAccount[] = useMemo(() => nsqsData?.payableAccounts ?? [], [nsqsData?.payableAccounts]);

src/pages/workspace/accounting/nsqs/import/NSQSCustomersDisplayedAsPage.tsx

@@ -23,7 +23,7 @@ function NSQSCustomersDisplayedAsPage({policy}: WithPolicyProps) {
     const styles = useThemeStyles();
     const policyID = policy?.id;
     const nsqsConfig = policy?.connections?.netsuiteQuickStart?.config;
-    const importType = nsqsConfig?.syncOptions.mapping.customers ?? CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
+    const importType = nsqsConfig?.syncOptions?.mapping?.customers ?? CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
 
     const sectionData: Array<SelectorType<Option>> = Options.map((option) => ({
         keyForList: option,

src/pages/workspace/accounting/nsqs/import/NSQSCustomersPage.tsx

@@ -23,7 +23,7 @@ function NSQSCustomersPage({policy}: WithPolicyProps) {
     const styles = useThemeStyles();
     const policyID = policy?.id;
     const nsqsConfig = policy?.connections?.netsuiteQuickStart?.config;
-    const importType = nsqsConfig?.syncOptions.mapping.customers ?? CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
+    const importType = nsqsConfig?.syncOptions?.mapping?.customers ?? CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
     const isImportEnabled = importType !== CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
 
     const toggleImport = useCallback(() => {

src/pages/workspace/accounting/nsqs/import/NSQSImportPage.tsx

@@ -19,8 +19,8 @@ function NSQSImportPage({policy}: WithPolicyProps) {
     const styles = useThemeStyles();
     const policyID = policy?.id;
     const nsqsConfig = policy?.connections?.netsuiteQuickStart?.config;
-    const customersImportType = nsqsConfig?.syncOptions.mapping.customers ?? CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
-    const projectsImportType = nsqsConfig?.syncOptions.mapping.projects ?? CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
+    const customersImportType = nsqsConfig?.syncOptions?.mapping?.customers ?? CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
+    const projectsImportType = nsqsConfig?.syncOptions?.mapping?.projects ?? CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
 
     return (
         <ConnectionLayout

src/pages/workspace/accounting/nsqs/import/NSQSProjectsDisplayedAsPage.tsx

@@ -23,7 +23,7 @@ function NSQSProjectsDisplayedAsPage({policy}: WithPolicyProps) {
     const styles = useThemeStyles();
     const policyID = policy?.id;
     const nsqsConfig = policy?.connections?.netsuiteQuickStart?.config;
-    const importType = nsqsConfig?.syncOptions.mapping.projects ?? CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
+    const importType = nsqsConfig?.syncOptions?.mapping?.projects ?? CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
 
     const sectionData: Array<SelectorType<Option>> = Options.map((option) => ({
         keyForList: option,

src/pages/workspace/accounting/nsqs/import/NSQSProjectsPage.tsx

@@ -23,7 +23,7 @@ function NSQSProjectsPage({policy}: WithPolicyProps) {
     const styles = useThemeStyles();
     const policyID = policy?.id;
     const nsqsConfig = policy?.connections?.netsuiteQuickStart?.config;
-    const importType = nsqsConfig?.syncOptions.mapping.projects ?? CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
+    const importType = nsqsConfig?.syncOptions?.mapping?.projects ?? CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
     const isImportEnabled = importType !== CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES.NETSUITE_DEFAULT;
 
     const toggleImport = useCallback(() => {

src/types/onyx/Policy.ts

@@ -1105,7 +1105,7 @@ type NSQSConnectionData = {
  */
 type NSQSConnectionConfig = OnyxCommon.OnyxValueWithOfflineFeedback<{
     /** Configuration of automatic synchronization from NSQS to the app */
-    autoSync: {
+    autoSync?: {
         /** Job ID of the synchronization */
         jobID: string;
 
@@ -1114,9 +1114,9 @@ type NSQSConnectionConfig = OnyxCommon.OnyxValueWithOfflineFeedback<{
     };
 
     /** Configuration options pertaining to sync */
-    syncOptions: {
+    syncOptions?: {
         /** Configuration of import settings from NSQS to Expensify */
-        mapping: {
+        mapping?: {
             /** How NSQS customers are displayed as */
             customers: ValueOf<typeof CONST.NSQS_INTEGRATION_ENTITY_MAP_TYPES>;
 
@@ -1136,7 +1136,7 @@ type NSQSConnectionConfig = OnyxCommon.OnyxValueWithOfflineFeedback<{
 
     /** NSQS credentials */
     credentials: {
-        /** Encrypted token for NSQS authentification */
+        /** Encrypted token for NSQS authentication */
         accessToken: string;
 
         /** The company ID */