Merge pull request #42470 from Expensify/rodrigo-fix-hold-text

Adds translation for hold violation

Author: puneetlath

src/CONST.ts

@@ -3675,6 +3675,7 @@ const CONST = {
         TAX_OUT_OF_POLICY: 'taxOutOfPolicy',
         TAX_RATE_CHANGED: 'taxRateChanged',
         TAX_REQUIRED: 'taxRequired',
+        HOLD: 'hold',
     },
 
     /** Context menu types */

src/hooks/useViolations.ts

@@ -5,7 +5,7 @@ import type {TransactionViolation, ViolationName} from '@src/types/onyx';
 /**
  * Names of Fields where violations can occur.
  */
-type ViolationField = 'amount' | 'billable' | 'category' | 'comment' | 'date' | 'merchant' | 'receipt' | 'tag' | 'tax';
+type ViolationField = 'amount' | 'billable' | 'category' | 'comment' | 'date' | 'merchant' | 'receipt' | 'tag' | 'tax' | 'none';
 
 /**
  * Map from Violation Names to the field where that violation can occur.
@@ -44,6 +44,7 @@ const violationFields: Record<ViolationName, ViolationField> = {
     taxOutOfPolicy: 'tax',
     taxRateChanged: 'tax',
     taxRequired: 'tax',
+    hold: 'none',
 };
 
 type ViolationsMap = Map<ViolationField, TransactionViolation[]>;

src/languages/en.ts

@@ -3063,6 +3063,7 @@ export default {
         taxOutOfPolicy: ({taxName}: ViolationsTaxOutOfPolicyParams) => `${taxName ?? 'Tax'} no longer valid`,
         taxRateChanged: 'Tax rate was modified',
         taxRequired: 'Missing tax rate',
+        hold: 'Hold',
     },
     violationDismissal: {
         rter: {

src/languages/es.ts

@@ -3567,6 +3567,7 @@ export default {
         taxOutOfPolicy: ({taxName}: ViolationsTaxOutOfPolicyParams) => `${taxName ?? 'El impuesto'} ya no es válido`,
         taxRateChanged: 'La tasa de impuesto fue modificada',
         taxRequired: 'Falta la tasa de impuesto',
+        hold: 'Bloqueada',
     },
     violationDismissal: {
         rter: {

src/libs/Violations/ViolationsUtils.ts

@@ -280,6 +280,8 @@ const ViolationsUtils = {
                 return translate('violations.taxRateChanged');
             case 'taxRequired':
                 return translate('violations.taxRequired');
+            case 'hold':
+                return translate('violations.hold');
             default:
                 // The interpreter should never get here because the switch cases should be exhaustive.
                 // If typescript is showing an error on the assertion below it means the switch statement is out of