Skip to content

Commit 555861c

Browse files
committed
Apply review changes
1 parent 4b0354a commit 555861c

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

+8-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,14 @@ function BottomTabBar({isLoadingApp = false}: PurposeForUsingExpensifyModalProps
5050
}
5151

5252
Welcome.isOnboardingFlowCompleted({
53-
onNotCompleted: () => Navigation.navigate(ROUTES.ONBOARDING_PURPOSE),
53+
onNotCompleted: () =>
54+
Navigation.navigate(
55+
// Uncomment once Stage 1 Onboarding Flow is ready
56+
//
57+
// ROUTES.ONBOARDING_PERSONAL_DETAILS
58+
//
59+
ROUTES.ONBOARD,
60+
),
5461
});
5562
// eslint-disable-next-line react-hooks/exhaustive-deps
5663
}, [isLoadingApp]);

src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

+2-5
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ function BaseOnboardingPersonalDetails({currentUserPersonalDetails, shouldUseNat
6161
});
6262

6363
Navigation.dismissModal();
64+
6465
// Only navigate to concierge chat when central pane is visible
6566
// Otherwise stay on the chats screen.
6667
if (isSmallScreenWidth) {
@@ -110,18 +111,14 @@ function BaseOnboardingPersonalDetails({currentUserPersonalDetails, shouldUseNat
110111
return errors;
111112
};
112113

113-
const handleGoBack = useCallback(() => {
114-
Navigation.goBack();
115-
}, []);
116-
117114
const PersonalDetailsFooterInstance = <OfflineIndicator />;
118115

119116
return (
120117
<View style={[styles.h100, styles.defaultModalContainer, shouldUseNativeStyles && styles.pt8]}>
121118
<HeaderWithBackButton
122119
shouldShowBackButton
123120
progressBarPercentage={OPEN_WORK_PAGE_PURPOSES.includes(onboardingPurposeSelected ?? '') ? 50 : 75}
124-
onBackButtonPress={handleGoBack}
121+
onBackButtonPress={Navigation.goBack}
125122
/>
126123
<KeyboardAvoidingView
127124
style={[styles.flex1, styles.dFlex]}

src/pages/OnboardingWork/BaseOnboardingWork.tsx

+2-5
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ function BaseOnboardingWork({currentUserPersonalDetails, shouldUseNativeStyles,
5757
);
5858

5959
Navigation.dismissModal();
60+
6061
// Only navigate to concierge chat when central pane is visible
6162
// Otherwise stay on the chats screen.
6263
if (isSmallScreenWidth) {
@@ -89,18 +90,14 @@ function BaseOnboardingWork({currentUserPersonalDetails, shouldUseNativeStyles,
8990
return errors;
9091
};
9192

92-
const handleGoBack = useCallback(() => {
93-
Navigation.goBack();
94-
}, []);
95-
9693
const WorkFooterInstance = <OfflineIndicator />;
9794

9895
return (
9996
<View style={[styles.h100, styles.defaultModalContainer, shouldUseNativeStyles && styles.pt8]}>
10097
<HeaderWithBackButton
10198
shouldShowBackButton
10299
progressBarPercentage={75}
103-
onBackButtonPress={handleGoBack}
100+
onBackButtonPress={Navigation.goBack}
104101
/>
105102
<KeyboardAvoidingView
106103
style={[styles.flex1, styles.dFlex]}

0 commit comments

Comments
 (0)