Skip to content

Commit 31d9edd

Browse files
authored
Revert "[No QA]Add Firebase distribution for iOS and Android staging builds"
1 parent 73fcb8b commit 31d9edd

File tree

5 files changed

+5
-52
lines changed

5 files changed

+5
-52
lines changed

.github/workflows/deploy.yml

+2-20
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ jobs:
137137
- name: Setup Node
138138
id: setup-node
139139
uses: ./.github/actions/composite/setupNode
140-
with:
140+
with:
141141
IS_HYBRID_BUILD: 'true'
142142

143143
- name: Run grunt build
@@ -166,7 +166,6 @@ jobs:
166166
env:
167167
OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}
168168
run: |
169-
op document get --output ./firebase.json firebase.json
170169
op document get --output ./upload-key.keystore upload-key.keystore
171170
op document get --output ./android-fastlane-json-key.json android-fastlane-json-key.json
172171
# Copy the keystore to the Android directory for Fullstory
@@ -231,10 +230,6 @@ jobs:
231230
env:
232231
BROWSERSTACK: ${{ secrets.BROWSERSTACK }}
233232

234-
- name: Upload Android build to Firebase distribution
235-
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
236-
run: bundle exec fastlane android upload_firebase_distribution
237-
238233
- name: Upload Android build artifact
239234
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
240235
uses: actions/upload-artifact@v4
@@ -355,15 +350,6 @@ jobs:
355350
max_attempts: 5
356351
command: scripts/pod-install.sh
357352

358-
- name: Install 1Password CLI
359-
uses: 1password/install-cli-action@v1
360-
361-
- name: Load files from 1Password
362-
env:
363-
OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}
364-
run: |
365-
op document get --output ./firebase.json firebase.json
366-
367353
- name: Decrypt AppStore profile
368354
run: cd ios && gpg --quiet --batch --yes --decrypt --passphrase="$LARGE_SECRET_PASSPHRASE" --output NewApp_AppStore.mobileprovision NewApp_AppStore.mobileprovision.gpg
369355
env:
@@ -407,10 +393,6 @@ jobs:
407393
env:
408394
BROWSERSTACK: ${{ secrets.BROWSERSTACK }}
409395

410-
- name: Upload iOS build to Firebase distribution
411-
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
412-
run: bundle exec fastlane ios upload_firebase_distribution
413-
414396
- name: Upload iOS sourcemaps artifact
415397
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
416398
uses: actions/upload-artifact@v4
@@ -469,7 +451,7 @@ jobs:
469451
- name: Setup Node
470452
id: setup-node
471453
uses: ./.github/actions/composite/setupNode
472-
with:
454+
with:
473455
IS_HYBRID_BUILD: 'true'
474456

475457
- name: Setup Ruby

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ DerivedData
2424
*.p12
2525
*.mobileprovision
2626
ios-fastlane-json-key.json
27-
firebase.json
2827
**/.xcode.env.local
2928

3029
# Android/IntelliJ

Gemfile.lock

+3-11
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,6 @@ GEM
165165
apktools (~> 0.7)
166166
aws-sdk-s3 (~> 1)
167167
mime-types (~> 3.3)
168-
fastlane-plugin-firebase_app_distribution (0.10.0)
169-
google-apis-firebaseappdistribution_v1 (~> 0.3.0)
170-
google-apis-firebaseappdistribution_v1alpha (~> 0.2.0)
171168
fastlane-sirp (1.0.0)
172169
sysrandom (~> 1.0)
173170
ffi (1.17.0)
@@ -187,10 +184,6 @@ GEM
187184
representable (~> 3.0)
188185
retriable (>= 2.0, < 4.a)
189186
rexml
190-
google-apis-firebaseappdistribution_v1 (0.3.0)
191-
google-apis-core (>= 0.11.0, < 2.a)
192-
google-apis-firebaseappdistribution_v1alpha (0.2.0)
193-
google-apis-core (>= 0.11.0, < 2.a)
194187
google-apis-iamcredentials_v1 (0.17.0)
195188
google-apis-core (>= 0.11.0, < 2.a)
196189
google-apis-playcustomapp_v1 (0.13.0)
@@ -236,7 +229,7 @@ GEM
236229
molinillo (0.8.0)
237230
multi_json (1.15.0)
238231
multipart-post (2.4.1)
239-
nanaimo (0.3.0)
232+
nanaimo (0.4.0)
240233
nap (1.1.0)
241234
naturally (2.2.1)
242235
netrc (0.11.0)
@@ -281,12 +274,12 @@ GEM
281274
uber (0.1.0)
282275
unicode-display_width (2.6.0)
283276
word_wrap (1.0.0)
284-
xcodeproj (1.25.1)
277+
xcodeproj (1.27.0)
285278
CFPropertyList (>= 2.3.3, < 4.0)
286279
atomos (~> 0.1.3)
287280
claide (>= 1.0.2, < 2.0)
288281
colored2 (~> 3.1)
289-
nanaimo (~> 0.3.0)
282+
nanaimo (~> 0.4.0)
290283
rexml (>= 3.3.6, < 4.0)
291284
xcpretty (0.3.0)
292285
rouge (~> 2.0.7)
@@ -305,7 +298,6 @@ DEPENDENCIES
305298
cocoapods (= 1.15.2)
306299
fastlane (~> 2, >= 2.222.0)
307300
fastlane-plugin-aws_s3
308-
fastlane-plugin-firebase_app_distribution
309301
xcodeproj (< 1.26.0)
310302
xcpretty (~> 0)
311303

fastlane/Fastfile

-19
Original file line numberDiff line numberDiff line change
@@ -197,16 +197,6 @@ platform :android do
197197
)
198198
end
199199

200-
desc "Upload app to Firebase distribution"
201-
lane :upload_firebase_distribution do
202-
firebase_app_distribution(
203-
app: "1:1008697809946:android:2e48f9ffe8d0b6a2",
204-
service_credentials_file: "./firebase.json",
205-
android_artifact_path: ENV[KEY_GRADLE_AAB_PATH],
206-
android_artifact_type: "AAB"
207-
)
208-
end
209-
210200
desc "Upload HybridApp to Google Play for internal testing"
211201
lane :upload_google_play_internal_hybrid do
212202
# Google is very unreliable, so we retry a few times
@@ -517,15 +507,6 @@ platform :ios do
517507
sh("echo '{\"ipa_path\": \"#{lane_context[SharedValues::S3_IPA_OUTPUT_PATH]}\",\"html_path\": \"#{lane_context[SharedValues::S3_HTML_OUTPUT_PATH]}\"}' > ../ios_paths.json")
518508
end
519509

520-
desc "Upload app to Firebase distribution"
521-
lane :upload_firebase_distribution do
522-
firebase_app_distribution(
523-
app: "1:1008697809946:ios:3ffad71f664f2886",
524-
service_credentials_file: "./firebase.json",
525-
ipa_path: ENV[KEY_IPA_PATH],
526-
)
527-
end
528-
529510
desc "Upload app to TestFlight"
530511
lane :upload_testflight do
531512
upload_to_testflight(

fastlane/Pluginfile

-1
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,3 @@
33
# Ensure this file is checked in to source control!
44

55
gem 'fastlane-plugin-aws_s3'
6-
gem 'fastlane-plugin-firebase_app_distribution'

0 commit comments

Comments
 (0)