Skip to content

Commit 2bde8f2

Browse files
authored
Merge pull request #51873 from Expensify/andrew-app-file
[No QA]Use explicit `app_identifier` to prevent build errors
2 parents fa5007e + 423bce2 commit 2bde8f2

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

fastlane/Appfile

-7
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,3 @@
22
apple_id("ios@expensify.com")
33
itc_team_id("152696")
44
team_id("368M544MTT")
5-
6-
for_lane :build_hybrid, :build_unsigned_hybrid, :upload_testflight_hybrid do
7-
# For HybridApp build tasks, use the OldApp bundle identifier
8-
app_identifier("com.expensify.expensifylite")
9-
else
10-
app_identifier("com.expensify.expensify")
11-
end

fastlane/Fastfile

+9-1
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,7 @@ platform :ios do
274274
)
275275

276276
build_app(
277+
app_identifier: "com.chat.expensify.chat",
277278
workspace: "./ios/NewExpensify.xcworkspace",
278279
scheme: "New Expensify",
279280
output_name: "New Expensify.ipa",
@@ -304,6 +305,7 @@ platform :ios do
304305
)
305306

306307
build_app(
308+
app_identifier: "com.expensify.expensifylite",
307309
workspace: "../iOS/Expensify.xcworkspace",
308310
scheme: "Expensify",
309311
output_name: "Expensify.ipa",
@@ -324,6 +326,7 @@ platform :ios do
324326
lane :build_unsigned do
325327
ENV["ENVFILE"]=".env.production"
326328
build_app(
329+
app_identifier: "com.chat.expensify.chat",
327330
workspace: "./ios/NewExpensify.xcworkspace",
328331
scheme: "New Expensify"
329332
)
@@ -334,6 +337,7 @@ platform :ios do
334337
lane :build_unsigned_hybrid do
335338
ENV["ENVFILE"]="../Mobile-Expensify/.env.production.hybridapp"
336339
build_app(
340+
app_identifier: "com.expensify.expensifylite",
337341
workspace: "../Mobile-Expensify/iOS/Expensify.xcworkspace",
338342
scheme: "Expensify"
339343
)
@@ -355,6 +359,7 @@ platform :ios do
355359
)
356360

357361
build_app(
362+
app_identifier: "com.chat.expensify.chat",
358363
workspace: "./ios/NewExpensify.xcworkspace",
359364
skip_profile_detection: true,
360365
scheme: "New Expensify AdHoc",
@@ -388,6 +393,7 @@ platform :ios do
388393
desc "Upload app to TestFlight"
389394
lane :upload_testflight do
390395
upload_to_testflight(
396+
app_identifier: "com.chat.expensify.chat",
391397
api_key_path: "./ios/ios-fastlane-json-key.json",
392398
distribute_external: true,
393399
notify_external_testers: true,
@@ -421,6 +427,7 @@ platform :ios do
421427
desc "Upload HybridApp to TestFlight"
422428
lane :upload_testflight_hybrid do
423429
upload_to_testflight(
430+
app_identifier: "com.expensify.expensifylite",
424431
api_key_path: "./ios/ios-fastlane-json-key.json",
425432
distribute_external: true,
426433
notify_external_testers: true,
@@ -452,9 +459,10 @@ platform :ios do
452459
)
453460
end
454461

455-
desc "Submit app to App Store Review"
462+
desc "Submit app for production App Store Review"
456463
lane :submit_for_review do
457464
deliver(
465+
app_identifier: "com.chat.expensify.chat",
458466
api_key_path: "./ios/ios-fastlane-json-key.json",
459467

460468
# Skip HTMl report verification

0 commit comments

Comments
 (0)