fix duplicated personal details #53579

This is a more effective implementation for https://github.com/Expensify/App/pull/54147/files which i reverted in this PR

Author: hannojg

src/hooks/useFastSearchFromOptions.ts

@@ -42,6 +42,7 @@ function useFastSearchFromOptions(
                     const displayName = option.participantsList?.[0]?.displayName ?? '';
                     return [option.login ?? '', option.login !== displayName ? displayName : ''].join();
                 },
+                uniqueId: (option) => option.login,
             },
             {
                 data: options.recentReports,

src/libs/FastSearch.ts

@@ -13,6 +13,14 @@ type SearchableData<T> = {
      * If you have multiple fields that should be searchable, simply concat them to the string and return it.
      */
     toSearchableString: (data: T) => string;
+
+    /**
+     * Gives the possibility to identify data by a unique attribute. Assume you have to search results with the same text they might be valid
+     * and represent different data. In this case, you can provide a function that returns a unique identifier for the data.
+     * If multiple items with the same identifier are found, only the first one will be returned.
+     * This fixes: https://github.com/Expensify/App/issues/53579
+     */
+    uniqueId?: (data: T) => string | undefined;
 };
 
 // There are certain characters appear very often in our search data (email addresses), which we don't need to search for.
@@ -72,6 +80,7 @@ function createFastSearch<T>(dataSets: Array<SearchableData<T>>) {
         const result = tree.findSubstring(Array.from(numeric));
 
         const resultsByDataSet = Array.from({length: dataSets.length}, () => new Set<T>());
+        const uniqueMap: Record<number, Record<string, T>> = {};
         // eslint-disable-next-line @typescript-eslint/prefer-for-of
         for (let i = 0; i < result.length; i++) {
             const occurrenceIndex = result[i];
@@ -85,6 +94,26 @@ function createFastSearch<T>(dataSets: Array<SearchableData<T>>) {
             if (!item) {
                 throw new Error(`[FastSearch] The item with index ${itemIndexInDataSet} in dataset ${dataSetIndex} is not defined`);
             }
+
+            // Check for uniqueness eventually
+            const getUniqueId = dataSets[dataSetIndex].uniqueId;
+            if (getUniqueId) {
+                const uniqueId = getUniqueId(item);
+                if (!uniqueId) {
+                    // eslint-disable-next-line no-continue
+                    continue;
+                }
+                const hasId = uniqueMap[dataSetIndex]?.[uniqueId];
+                if (hasId) {
+                    // eslint-disable-next-line no-continue
+                    continue;
+                }
+                if (!uniqueMap[dataSetIndex]) {
+                    uniqueMap[dataSetIndex] = {};
+                }
+                uniqueMap[dataSetIndex][uniqueId] = item;
+            }
+
             resultsByDataSet[dataSetIndex].add(item);
         }
 

tests/unit/FastSearchTest.ts

@@ -115,4 +115,55 @@ describe('FastSearch', () => {
         expect(search('test.user')).toEqual([['test.user@example.com']]);
         expect(search('examplecom')).toEqual([['test.user@example.com']]);
     });
+
+    it('should filter duplicate IDs', () => {
+        const {search} = FastSearch.createFastSearch([
+            {
+                data: [
+                    {
+                        text: 'qa.guide@team.expensify.com',
+                        alternateText: 'qa.guide@team.expensify.com',
+                        keyForList: '14365522',
+                        isSelected: false,
+                        isDisabled: false,
+                        accountID: 14365522,
+                        login: 'qa.guide@team.expensify.com',
+                        icons: [
+                            {
+                                source: 'https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_11.png',
+                                type: 'avatar',
+                                name: 'qa.guide@team.expensify.com',
+                                id: 14365522,
+                            },
+                        ],
+                        reportID: '',
+                    },
+                    {
+                        text: 'qa.guide@team.expensify.com',
+                        alternateText: 'qa.guide@team.expensify.com',
+                        keyForList: '714749267',
+                        isSelected: false,
+                        isDisabled: false,
+                        accountID: 714749267,
+                        login: 'qa.guide@team.expensify.com',
+                        icons: [
+                            {
+                                source: 'ƒ SvgFallbackAvatar(props)',
+                                type: 'avatar',
+                                name: 'qa.guide@team.expensify.com',
+                                id: 714749267,
+                            },
+                        ],
+                        reportID: '',
+                    },
+                ],
+                toSearchableString: (data) => data.text,
+                uniqueId: (data) => data.login,
+            },
+        ]);
+
+        const [result] = search('qa.g');
+        // The both items are represented using the same string.
+        expect(result).toHaveLength(1);
+    });
 });