Merge pull request #53558 from Themoonalsofall/update-display-name

update display name when update legal name

Author: techievivek

src/libs/TransactionUtils/index.ts

@@ -1288,11 +1288,10 @@ function compareDuplicateTransactionFields(
     return {keep, change};
 }
 
-function getTransactionID(threadReportID: string | undefined): string | undefined {
+function getTransactionID(threadReportID?: string): string | undefined {
     if (!threadReportID) {
         return;
     }
-
     const report = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${threadReportID}`];
     const parentReportAction = isThread(report) ? getReportAction(report.parentReportID, report.parentReportActionID) : undefined;
     const IOUTransactionID = isMoneyRequestAction(parentReportAction) ? getOriginalMessage(parentReportAction)?.IOUTransactionID : undefined;

src/libs/actions/PersonalDetails.ts

@@ -37,7 +37,7 @@ Onyx.connect({
     key: ONYXKEYS.SESSION,
     callback: (val) => {
         currentUserEmail = val?.email ?? '';
-        currentUserAccountID = val?.accountID ?? -1;
+        currentUserAccountID = val?.accountID ?? CONST.DEFAULT_NUMBER_ID;
     },
 });
 
@@ -121,20 +121,36 @@ function updateDisplayName(firstName: string, lastName: string) {
 
 function updateLegalName(legalFirstName: string, legalLastName: string) {
     const parameters: UpdateLegalNameParams = {legalFirstName, legalLastName};
-
-    API.write(WRITE_COMMANDS.UPDATE_LEGAL_NAME, parameters, {
-        optimisticData: [
-            {
-                onyxMethod: Onyx.METHOD.MERGE,
-                key: ONYXKEYS.PRIVATE_PERSONAL_DETAILS,
-                value: {
-                    legalFirstName,
-                    legalLastName,
+    const optimisticData: OnyxUpdate[] = [
+        {
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: ONYXKEYS.PRIVATE_PERSONAL_DETAILS,
+            value: {
+                legalFirstName,
+                legalLastName,
+            },
+        },
+    ];
+    // In case the user does not have a display name, we will update the display name based on the legal name
+    if (!allPersonalDetails?.[currentUserAccountID]?.firstName && !allPersonalDetails?.[currentUserAccountID]?.lastName) {
+        optimisticData.push({
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: ONYXKEYS.PERSONAL_DETAILS_LIST,
+            value: {
+                [currentUserAccountID]: {
+                    displayName: PersonalDetailsUtils.createDisplayName(currentUserEmail ?? '', {
+                        firstName: legalFirstName,
+                        lastName: legalLastName,
+                    }),
                 },
+                firstName: legalFirstName,
+                lastName: legalLastName,
             },
-        ],
+        });
+    }
+    API.write(WRITE_COMMANDS.UPDATE_LEGAL_NAME, parameters, {
+        optimisticData,
     });
-
     Navigation.goBack();
 }