Merge pull request #5929 from Expensify/jules-refactorPersonalDetailsPropType

[NO-QA] Refactor duplicated personalDetailsPropTypes

Author: Gonals

src/pages/NewChatPage.js

@@ -16,27 +16,14 @@ import ScreenWrapper from '../components/ScreenWrapper';
 import FullScreenLoadingIndicator from '../components/FullscreenLoadingIndicator';
 import withLocalize, {withLocalizePropTypes} from '../components/withLocalize';
 import compose from '../libs/compose';
-
-const personalDetailsPropTypes = PropTypes.shape({
-    /** The login of the person (either email or phone number) */
-    login: PropTypes.string.isRequired,
-
-    /** The URL of the person's avatar (there should already be a default avatar if
-    the person doesn't have their own avatar uploaded yet) */
-    avatar: PropTypes.string.isRequired,
-
-    /** This is either the user's full name, or their login if full name is an empty string */
-    displayName: PropTypes.string.isRequired,
-
-    ...withLocalizePropTypes,
-});
+import personalDetailsPropType from './personalDetailsPropType';
 
 const propTypes = {
     /** Beta features list */
     betas: PropTypes.arrayOf(PropTypes.string).isRequired,
 
     /** All of the personal details for everyone */
-    personalDetails: PropTypes.objectOf(personalDetailsPropTypes).isRequired,
+    personalDetails: personalDetailsPropType.isRequired,
 
     /** All reports shared with the user */
     reports: PropTypes.shape({
@@ -50,6 +37,8 @@ const propTypes = {
     }).isRequired,
 
     ...windowDimensionsPropTypes,
+
+    ...withLocalizePropTypes,
 };
 
 class NewChatPage extends Component {

src/pages/NewGroupPage.js

@@ -19,25 +19,14 @@ import compose from '../libs/compose';
 import Button from '../components/Button';
 import KeyboardAvoidingView from '../components/KeyboardAvoidingView';
 import FixedFooter from '../components/FixedFooter';
-
-const personalDetailsPropTypes = PropTypes.shape({
-    /** The login of the person (either email or phone number) */
-    login: PropTypes.string.isRequired,
-
-    /** The URL of the person's avatar (there should already be a default avatar if
-    the person doesn't have their own avatar uploaded yet) */
-    avatar: PropTypes.string.isRequired,
-
-    /** This is either the user's full name, or their login if full name is an empty string */
-    displayName: PropTypes.string.isRequired,
-});
+import personalDetailsPropType from './personalDetailsPropType';
 
 const propTypes = {
     /** Beta features list */
     betas: PropTypes.arrayOf(PropTypes.string).isRequired,
 
     /** All of the personal details for everyone */
-    personalDetails: PropTypes.objectOf(personalDetailsPropTypes).isRequired,
+    personalDetails: personalDetailsPropType.isRequired,
 
     /** All reports shared with the user */
     reports: PropTypes.shape({

src/pages/SearchPage.js

@@ -19,18 +19,7 @@ import CONST from '../CONST';
 import FullScreenLoadingIndicator from '../components/FullscreenLoadingIndicator';
 import withLocalize, {withLocalizePropTypes} from '../components/withLocalize';
 import compose from '../libs/compose';
-
-const personalDetailsPropTypes = PropTypes.shape({
-    /** The login of the person (either email or phone number) */
-    login: PropTypes.string.isRequired,
-
-    /** The URL of the person's avatar (there should already be a default avatar if
-    the person doesn't have their own avatar uploaded yet) */
-    avatar: PropTypes.string.isRequired,
-
-    /** This is either the user's full name, or their login if full name is an empty string */
-    displayName: PropTypes.string.isRequired,
-});
+import personalDetailsPropType from './personalDetailsPropType';
 
 const propTypes = {
     /* Onyx Props */
@@ -39,7 +28,7 @@ const propTypes = {
     betas: PropTypes.arrayOf(PropTypes.string).isRequired,
 
     /** All of the personal details for everyone */
-    personalDetails: PropTypes.objectOf(personalDetailsPropTypes).isRequired,
+    personalDetails: personalDetailsPropType.isRequired,
 
     /** All reports shared with the user */
     reports: PropTypes.shape({

src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsRequest.js

@@ -8,18 +8,7 @@ import ONYXKEYS from '../../../../ONYXKEYS';
 import withLocalize, {withLocalizePropTypes} from '../../../../components/withLocalize';
 import compose from '../../../../libs/compose';
 import {EXCLUDED_IOU_EMAILS} from '../../../../CONST';
-
-const personalDetailsPropTypes = PropTypes.shape({
-    /** The login of the person (either email or phone number) */
-    login: PropTypes.string.isRequired,
-
-    /** The URL of the person's avatar (there should already be a default avatar if the person doesn't have
-     * their own avatar uploaded yet) */
-    avatar: PropTypes.string.isRequired,
-
-    /** This is either the user's full name, or their login if full name is an empty string */
-    displayName: PropTypes.string.isRequired,
-});
+import personalDetailsPropType from '../../../personalDetailsPropType';
 
 const propTypes = {
     /** Beta features list */
@@ -32,7 +21,7 @@ const propTypes = {
     onAddParticipants: PropTypes.func.isRequired,
 
     /** All of the personal details for everyone */
-    personalDetails: PropTypes.objectOf(personalDetailsPropTypes).isRequired,
+    personalDetails: PropTypes.objectOf(personalDetailsPropType).isRequired,
 
     /** All reports shared with the user */
     reports: PropTypes.shape({

src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsSplit.js

@@ -13,18 +13,7 @@ import compose from '../../../../libs/compose';
 import Button from '../../../../components/Button';
 import Text from '../../../../components/Text';
 import FixedFooter from '../../../../components/FixedFooter';
-
-const personalDetailsPropTypes = PropTypes.shape({
-    // The login of the person (either email or phone number)
-    login: PropTypes.string.isRequired,
-
-    // The URL of the person's avatar (there should already be a default avatar if
-    // the person doesn't have their own avatar uploaded yet)
-    avatar: PropTypes.string.isRequired,
-
-    // This is either the user's full name, or their login if full name is an empty string
-    displayName: PropTypes.string.isRequired,
-});
+import personalDetailsPropType from '../../../personalDetailsPropType';
 
 const propTypes = {
     /** Beta features list */
@@ -51,7 +40,7 @@ const propTypes = {
     })),
 
     /** All of the personal details for everyone */
-    personalDetails: PropTypes.objectOf(personalDetailsPropTypes).isRequired,
+    personalDetails: PropTypes.objectOf(personalDetailsPropType).isRequired,
 
     /** All reports shared with the user */
     reports: PropTypes.shape({