Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make getdaft[dashboard] optional and not warn #3876

Closed
kevinjqliu opened this issue Feb 28, 2025 · 2 comments
Closed

make getdaft[dashboard] optional and not warn #3876

kevinjqliu opened this issue Feb 28, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@kevinjqliu
Copy link

Describe the bug

pyiceberg upgrading to use getdaft 0.4.5 fails CI, apache/iceberg-python#1739

Due to the warning statement about daft_dashboard import

Daft/daft/dashboard.py

Lines 14 to 28 in 5481c7e

def _dashboard_module():
try:
import daft_dashboard
except ImportError:
warnings.warn(
"Unable to import Daft's dashboard features"
"Consider re-installing Daft with the 'dashboard' feature installed, e.g.:"
'pip install "getdaft[dashboard]"'
)
raise
if not daft_dashboard.__file__:
raise ImportError
return daft_dashboard

We have CI to error on warnings

To Reproduce

No response

Expected behavior

No response

Component(s)

Other

Additional context

No response

@kevinjqliu kevinjqliu added bug Something isn't working needs triage labels Feb 28, 2025
@universalmind303
Copy link
Contributor

@raunakab could you take a look at this one.

@universalmind303
Copy link
Contributor

fixed via #3888.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants