Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency in write_mode between different write_ methods #3828

Open
universalmind303 opened this issue Feb 19, 2025 · 0 comments
Open

inconsistency in write_mode between different write_ methods #3828

universalmind303 opened this issue Feb 19, 2025 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@universalmind303
Copy link
Contributor

Describe the bug

for many of the write_ methods, there is a kwarg called either mode or write_mode. This should be consistent across all write_ methods. Many of them also have different modes available.

To Reproduce

def write_parquet(
  # ...
  write_mode: Literal["append", "overwrite", "overwrite-partitions"] = "append",
)

def write_csv(
  # ...
  write_mode: Literal["append", "overwrite", "overwrite-partitions"] = "append",
)

def write_iceberg(
  # ...
  mode: str = "append", # only supports (append | overwrite)
)

def write_deltalake(
  # ...
  mode: Literal["append", "overwrite", "error", "ignore"] = "append",
)

def write_lance(
  # ...
  mode: Literal["create", "append", "overwrite"] = "create",
)

Expected behavior

the write_ methods should have at a minimum a consistent naming. either write_mode or mode.

additionally, it would be nice if other write modes were supported for parquet/csv/iceberg (error & ignore)

Component(s)

Other

Additional context

No response

@universalmind303 universalmind303 added bug Something isn't working needs triage labels Feb 19, 2025
@universalmind303 universalmind303 changed the title inconsistency in kwargs between different write_ methods inconsistency in write_mode between different write_ methods Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

1 participant