Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FloorFilter: SiteAndFacility Manager appearing when panning map #783

Closed
bastianmorath opened this issue Jun 28, 2024 · 6 comments · Fixed by #820
Closed

FloorFilter: SiteAndFacility Manager appearing when panning map #783

bastianmorath opened this issue Jun 28, 2024 · 6 comments · Fixed by #820
Assignees
Labels
bug Something isn't working Effort - small A low level of effort to complete Priority - medium A medium-priority item

Comments

@bastianmorath
Copy link

When I add a FloorFilter to my map, then open and close the SiteAndFacilitySelector, then the SiteAndFacilitySelector shows again every time the map is panned (see video)

This can be fixed by not using a .constant binding as shown in the following screenshot.

Also, as a sidenote, you do not need to pass the $isSitesAndFacilitiesHidden to all the subviews in order to dismiss the sheet. You can use a '@Environment(.dismiss) private var dismiss' in the corresponding views, which simplifies the code a little bit.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-28.at.11.08.13.mov
image
@mhdostal mhdostal added bug Something isn't working Effort - small A low level of effort to complete Priority - medium A medium-priority item labels Jun 28, 2024
@mhdostal
Copy link
Member

@bastianmorath - Thank you for the issue, especially the detailed explanation; that helps a lot!

@dfeinzimer
Copy link
Collaborator

Hi @bastianmorath, thank you for the bug report!

Can you please confirm which version of the toolkit you're using? Whether it's 200.4.0 or earlier?

@bastianmorath
Copy link
Author

Hi @dfeinzimer, I've been using the newest version, 200.4.0.

@dfeinzimer
Copy link
Collaborator

@bastianmorath a PR has been merged for this issue and the issue should be fixed in the upcoming 200.5 release.

Thank you again for the report!

@dfeinzimer
Copy link
Collaborator

Hi @bastianmorath, the fix is available in 200.5.0 as of today.

@bastianmorath
Copy link
Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Effort - small A low level of effort to complete Priority - medium A medium-priority item
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants