Skip to content

Commit f6c364d

Browse files
committed
test: add cover test for comment property
1 parent 02adf61 commit f6c364d

File tree

1 file changed

+72
-0
lines changed

1 file changed

+72
-0
lines changed

internal/service/athena/database_test.go

+72
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,46 @@ func TestAccAthenaDatabase_basic(t *testing.T) {
3535
})
3636
}
3737

38+
func TestAccAthenaDatabase_description(t *testing.T) {
39+
rInt := sdkacctest.RandInt()
40+
dbName := sdkacctest.RandString(8)
41+
resource.ParallelTest(t, resource.TestCase{
42+
PreCheck: func() { acctest.PreCheck(t) },
43+
ErrorCheck: acctest.ErrorCheck(t, athena.EndpointsID),
44+
Providers: acctest.Providers,
45+
CheckDestroy: testAccCheckDatabaseDestroy,
46+
Steps: []resource.TestStep{
47+
{
48+
Config: testAccAthenaDatabaseCommentConfig(rInt, dbName, false),
49+
Check: resource.ComposeTestCheckFunc(
50+
testAccCheckDatabaseExists("aws_athena_database.hoge"),
51+
resource.TestCheckResourceAttr("aws_athena_database.hoge", "name", dbName),
52+
),
53+
},
54+
},
55+
})
56+
}
57+
58+
func TestAccAthenaDatabase_unescaped_description(t *testing.T) {
59+
rInt := sdkacctest.RandInt()
60+
dbName := sdkacctest.RandString(8)
61+
resource.ParallelTest(t, resource.TestCase{
62+
PreCheck: func() { acctest.PreCheck(t) },
63+
ErrorCheck: acctest.ErrorCheck(t, athena.EndpointsID),
64+
Providers: acctest.Providers,
65+
CheckDestroy: testAccCheckDatabaseDestroy,
66+
Steps: []resource.TestStep{
67+
{
68+
Config: testAccAthenaDatabaseUnescapedCommentConfig(rInt, dbName, false),
69+
Check: resource.ComposeTestCheckFunc(
70+
testAccCheckDatabaseExists("aws_athena_database.hoge"),
71+
resource.TestCheckResourceAttr("aws_athena_database.hoge", "name", dbName),
72+
),
73+
},
74+
},
75+
})
76+
}
77+
3878
func TestAccAthenaDatabase_encryption(t *testing.T) {
3979
rInt := sdkacctest.RandInt()
4080
dbName := sdkacctest.RandString(8)
@@ -354,6 +394,38 @@ resource "aws_athena_database" "hoge" {
354394
`, randInt, dbName, forceDestroy)
355395
}
356396

397+
func testAccAthenaDatabaseCommentConfig(randInt int, dbName string, forceDestroy bool) string {
398+
return fmt.Sprintf(`
399+
resource "aws_s3_bucket" "hoge" {
400+
bucket = "tf-test-athena-db-%[1]d"
401+
force_destroy = true
402+
}
403+
404+
resource "aws_athena_database" "hoge" {
405+
name = "%[2]s"
406+
bucket = aws_s3_bucket.hoge.bucket
407+
comment = "athena is a goddess"
408+
force_destroy = %[3]t
409+
}
410+
`, randInt, dbName, forceDestroy)
411+
}
412+
413+
func testAccAthenaDatabaseUnescapedCommentConfig(randInt int, dbName string, forceDestroy bool) string {
414+
return fmt.Sprintf(`
415+
resource "aws_s3_bucket" "hoge" {
416+
bucket = "tf-test-athena-db-%[1]d"
417+
force_destroy = true
418+
}
419+
420+
resource "aws_athena_database" "hoge" {
421+
name = "%[2]s"
422+
bucket = aws_s3_bucket.hoge.bucket
423+
comment = "athena's a goddess"
424+
force_destroy = %[3]t
425+
}
426+
`, randInt, dbName, forceDestroy)
427+
}
428+
357429
func testAccAthenaDatabaseWithKMSConfig(randInt int, dbName string, forceDestroy bool) string {
358430
return fmt.Sprintf(`
359431
resource "aws_kms_key" "hoge" {

0 commit comments

Comments
 (0)