Review: v1.9.3 to master #729

Jack-Works · 2020-02-03T08:54:41Z

Big Changes

Refactor on AdditionalContent 1886ee5
Remove WelcomBanner c8c953b

Notes

Add type coverage 161d5c3
Add red packet to storybook & refactor it 859613d 335aca6 5c3cbdc b899d41 689a76c 7b8c13c 3445b82
Refactor on a3c9b40

Discussions

We can recognize text in the link now, but it increase the code complicity. Switch to a markdown library might be better ( @neruthes )
~~Why shouldDisplayWelcome deprecated? ( @SunriseFox )~~

Todos

src/components/InjectedComponents/PostDialog.tsx , hasRedPacket should become a MaterialUI theme. ( @SunriseFox ? )
Maybe rename src/components/InjectedComponents/StructuredMessage/StructuredPluginWrapper.tsx
Add red packet related UI to storybook ( @SunriseFox ? )
Split useSettingsUI out to a separate file
Check the enum support for useSettingsUI
Change the design of MessageCenter in holoflows-kit (@Jack-Works )

Future todos:

Make SteganographyService more configurable (?)
Remove the spring festival special leading text (81b5c8a#diff-e07e5a7386945a884d7b9bbc226204a6R339 ) ( but when? @neruthes )
Resolve this todo https://github.com/DimensionDev/Maskbook/blob/v1.10.0/src/database/Persona/helpers.ts#L155 in createPersonaByMnemonic? ( @SunriseFox , @guanbinrui )

guanbinrui · 2020-02-04T02:27:21Z

How to resolve this todo https://github.com/DimensionDev/Maskbook/blob/v1.10.0/src/database/Persona/helpers.ts#L155 in createPersonaByMnemonic? ( @SunriseFox , @guanbinrui )

Use message center?

- injectPostDialogSpy

- SelectRecipientsUI

- render specific friends only in debug mode - #397 - close #673

SunriseFox · 2020-02-04T06:54:07Z

shouldDisplayWelcome: as our setup procedure changes, a user will always gain access permission first and then starts immersive setup (dashboard->provider instead of provider->dashboard, no longer need to input username from provider and open dashboard).

We need a new design about what to prompt if a user deletes their persona / disconnects all their profiles. @neruthes

…urpose

- Only Myself - Share to Everyone - close #642

Jack-Works · 2020-02-05T09:16:51Z

src/components/InjectedComponents/PostDialog.tsx

                                    const ref = getActivatedUI().typedMessageMetadata
                                    const next = new Map(ref.value.entries())
                                    next.delete('com.maskbook.red_packet:1')
                                    ref.value = next
+                                    if (props.onShareToEveryoneChanged) {
+                                        await sleep(300)
+                                        props.onShareToEveryoneChanged(false)


why add a delay here?

For resetting state of Share to Everyone chip to unselect. In addition, ref.value = next is async so wait a while to ensure really reseted.

maybe add a comment here

Jack-Works · 2020-02-05T11:24:10Z

shouldDisplayWelcome: as our setup procedure changes, a user will always gain access permission first and then starts immersive setup (dashboard->provider instead of provider->dashboard, no longer need to input username from provider and open dashboard).

We need a new design about what to prompt if a user deletes their persona / disconnects all their profiles. @neruthes

Should we remove all codes that related to shouldDisplayWelcome

neruthes · 2020-02-06T03:36:43Z

@Jack-Works: We can recognize text in the link now, but it increase the code complicity. Switch to a markdown library might be better

What text in what link? Could you offer additional context?

@Jack-Works: Remove the spring festival special leading text (81b5c8a#diff-e07e5a7386945a884d7b9bbc226204a6R339 ) ( but when? @neruthes )

Let us consult @Tedko for an answer.

Also, I would like to learn your ideas about DimensionDev/Maskbook-Talks#22.

@SunriseFox: We need a new design about what to prompt if a user deletes their persona / disconnects all their profiles.

The behavior has been defined in #407.

Upon loading Dashboard: If there is no Persona currently, Dashboard will be in pre-initialization state; otherwise, Dashboard will be in post-initialization state. This selection is made every time when Dashboard is loaded.

Nothings explicitly happens when the the user deletes all Personas. Next time the user loads Dashboard, the Dashboard will be displayed as Pre-Init state.

SunriseFox · 2020-02-06T07:50:07Z

@SunriseFox: We need a new design about what to prompt if a user deletes their persona / disconnects all their profiles.

The behavior has been defined in #407.

Upon loading Dashboard: If there is no Persona currently, Dashboard will be in pre-initialization state; otherwise, Dashboard will be in post-initialization state. This selection is made every time when Dashboard is loaded.

Nothings explicitly happens when the the user deletes all Personas. Next time the user loads Dashboard, the Dashboard will be displayed as Pre-Init state.

No. I am talking about what if

we have permissions to manipulate facebook / twitter page
the user has no persona and never opens dashboard

Tedko · 2020-02-06T08:05:20Z

@Jack-Works: Remove the spring festival special leading text (81b5c8a#diff-e07e5a7386945a884d7b9bbc226204a6R339 ) ( but when? @neruthes )

Let us consult @Tedko for an answer.

Also, I would like to learn your ideas about DimensionDev/Maskbook-Talks#22.

We can revise these text from 'Happy New Year etc' to 'Best Wish' etc, and remove hashtags . I guess we can do an update about leading text around 元宵节 -- ping me again when you are ready to publish a new version

neruthes · 2020-02-06T08:26:46Z

@SunriseFox: We need a new design about what to prompt if a user deletes their persona / disconnects all their profiles.

The behavior has been defined in #407.
Upon loading Dashboard: If there is no Persona currently, Dashboard will be in pre-initialization state; otherwise, Dashboard will be in post-initialization state. This selection is made every time when Dashboard is loaded.
Nothings explicitly happens when the the user deletes all Personas. Next time the user loads Dashboard, the Dashboard will be displayed as Pre-Init state.

No. I am talking about what if

we have permissions to manipulate facebook / twitter page

the user has no persona and never opens dashboard

Suggestion for initialization can be implemented in a way similar to #409, to be visible when the user visits a timeline page of a supported social network. I will note this for future reference.

Jack-Works and others added 3 commits February 3, 2020 18:25

refactor: rewrite additional post content to support typed message

7216d7f

refactor: change signature of post id

434f26f

refactor: change to mui style style overwriting

ccd4d1d

Jack-Works force-pushed the feature/review-1-10-x branch from 6217cd5 to ccd4d1d Compare February 3, 2020 10:26

Jack-Works added 4 commits February 3, 2020 19:08

refactor: re-order deps, add ok and err as serializable

2d6c771

refactor: make action button strongly typed again

8fa97fb

chore: add some comments

38cb8cd

chore: update deps & reduce use of require

5474427

guanbinrui added 3 commits February 4, 2020 10:42

refactor: remove unused component

94187be

- injectPostDialogSpy

refactor: remove unused variables

58c6384

- SelectRecipientsUI

refactor: move erc20 token settings into same folder

c2d8612

guanbinrui force-pushed the feature/review-1-10-x branch from 9fefe3a to c2d8612 Compare February 4, 2020 02:43

guanbinrui and others added 7 commits February 4, 2020 10:55

fix: render only in debug mode

65dabec

- render specific friends only in debug mode - #397 - close #673

chore: clean unused code

7c9561f

test: add type coverage

161d5c3

chore: remove dup types

1ad6c5e

docs: add storybook for RedPacket

859613d

chore: themed hasRedPacket

8d75d77

docs: enhance RedPacket storybook

335aca6

Jack-Works and others added 9 commits February 4, 2020 15:05

refactor: refactor the RedPacketWithState and add storybook

5c3cbdc

refactor: split RedPacketDialog into logic and UI

b899d41

fix: identifier map

de2010e

refactor: rename BackupRestoreTab to AbstractTab since its multiple p…

96e229a

…urpose

refactor: refactor red packet dialog

689a76c

docs: add decrypted post with red packet in storybook

7b8c13c

fix: facebook comment decrypt and encrypt, close #712

6e28f4e

chore: rename WithRedPacket to RedPacketInDecryptedPost

dea4623

crefactor: refactor red packet in decrypted post

3445b82

fix: add recipient option

c515899

- Only Myself - Share to Everyone - close #642

guanbinrui force-pushed the feature/review-1-10-x branch from d34967a to eaff769 Compare February 5, 2020 07:51

guanbinrui added 4 commits February 5, 2020 16:00

fix: laggy typing

ae61e43

fix: post button state

28cee01

fix: recipient chip state

2d7b6a2

fix: reset post dialog after delete red packet

d19514c

guanbinrui force-pushed the feature/review-1-10-x branch from eaff769 to d19514c Compare February 5, 2020 08:01

Jack-Works commented Feb 5, 2020

View reviewed changes

Jack-Works added 2 commits February 5, 2020 19:18

refactor: refactor useSettingsUI

a3c9b40

chore: rename StructuredPluginWrapper

a43b1f3

Jack-Works added 3 commits February 6, 2020 14:22

fix: type error

cccfc73

chore: remove welcome banner related code

c8c953b

chore: upgrade holoflows kit

078bbed

Jack-Works requested review from guanbinrui and SunriseFox February 6, 2020 09:57

guanbinrui previously approved these changes Feb 6, 2020

View reviewed changes

chore: upgrade kit

c770bb2

Jack-Works dismissed guanbinrui’s stale review via c770bb2 February 7, 2020 07:55

Jack-Works merged commit 837f81d into master Feb 7, 2020

Jack-Works deleted the feature/review-1-10-x branch February 7, 2020 08:11

BertsLifee mentioned this pull request May 3, 2024

[Snyk] Security upgrade opensea-js from 1.2.8 to 6.0.0 BertsLifee/Maskbook#1

Open

BertsLifee mentioned this pull request Oct 16, 2024

[Snyk] Fix for 2 vulnerabilities BertsLifee/Maskbook#59

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Review: v1.9.3 to master #729

Review: v1.9.3 to master #729

Jack-Works commented Feb 3, 2020 •

edited by Tedko

Loading

guanbinrui commented Feb 4, 2020

SunriseFox commented Feb 4, 2020

Jack-Works Feb 5, 2020

guanbinrui Feb 5, 2020 •

edited

Loading

Jack-Works Feb 5, 2020

Jack-Works commented Feb 5, 2020

neruthes commented Feb 6, 2020

SunriseFox commented Feb 6, 2020

Tedko commented Feb 6, 2020

neruthes commented Feb 6, 2020

Review: v1.9.3 to master #729

Review: v1.9.3 to master #729

Conversation

Jack-Works commented Feb 3, 2020 • edited by Tedko Loading

Big Changes

Notes

Discussions

Todos

Future todos:

guanbinrui commented Feb 4, 2020

SunriseFox commented Feb 4, 2020

Jack-Works Feb 5, 2020

Choose a reason for hiding this comment

guanbinrui Feb 5, 2020 • edited Loading

Choose a reason for hiding this comment

Jack-Works Feb 5, 2020

Choose a reason for hiding this comment

Jack-Works commented Feb 5, 2020

neruthes commented Feb 6, 2020

SunriseFox commented Feb 6, 2020

Tedko commented Feb 6, 2020

neruthes commented Feb 6, 2020

Jack-Works commented Feb 3, 2020 •

edited by Tedko

Loading

guanbinrui Feb 5, 2020 •

edited

Loading