Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some release bug #6151

Merged
merged 2 commits into from
Apr 26, 2022
Merged

fix: some release bug #6151

merged 2 commits into from
Apr 26, 2022

Conversation

Lanttcat
Copy link
Contributor

@Lanttcat Lanttcat commented Apr 25, 2022 •
edited by guanbinrui
Loading

Description

Closes #MF-542

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@Lanttcat Lanttcat changed the title fix: should show tip on other chain fix: some release bug Apr 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2022 •
edited
Loading

🚀 Deployed on https://62666c18aa84587433b28dbb--compassionate-northcutt-326a3a.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 25, 2022 06:10 Inactive
Jack-Works
Jack-Works previously approved these changes Apr 25, 2022
View reviewed changes
@github-actions github-actions bot temporarily deployed to pull request April 25, 2022 09:38 Inactive
@wenluomask
Copy link
Contributor

Also fixed #MF-567.

@Lanttcat Lanttcat merged commit 3c3b4d8 into develop Apr 26, 2022
@Lanttcat Lanttcat deleted the fix/bugs-lantt branch April 26, 2022 09:06
@Jsn2win Jsn2win mentioned this pull request Nov 28, 2023
Open
This was referenced Mar 22, 2024
Open
Open
@yisiliu yisiliu mentioned this pull request Mar 24, 2024
Closed
@yisiliu yisiliu mentioned this pull request Apr 18, 2024
Closed
This was referenced Oct 16, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guanbinrui guanbinrui guanbinrui approved these changes

@zhouhanseng zhouhanseng zhouhanseng approved these changes

@Jack-Works Jack-Works Jack-Works left review comments

Assignees
No one assigned
Labels
Test: Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lanttcat @wenluomask @Jack-Works @guanbinrui @zhouhanseng