Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tips): some improvement #6129

Merged
merged 1 commit into from
Apr 22, 2022
Merged

fix(tips): some improvement #6129

merged 1 commit into from
Apr 22, 2022

Conversation

UncleBill
Copy link
Contributor

No description provided.

UncleBill
UncleBill commented Apr 22, 2022
View reviewed changes
packages/mask/src/plugins/Tips/SNSAdaptor/bodyViews/Wallets.tsx
@@ -4,7 +4,7 @@ import { Typography } from '@mui/material'
import { memo, useCallback, useState } from 'react'
import { useI18N } from '../../../../utils'
import { DisconnectWalletDialog } from '../components/DisconnectDialog'
import { WalletCom } from '../components/WalletCom'
import { WalletItem } from '../components/WalletItem'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We rarely use -Com for Component

@UncleBill UncleBill force-pushed the fix/tips-setting branch 2 times, most recently from 4458154 to b46d451 Compare April 22, 2022 13:42
@UncleBill UncleBill merged commit 40bb35c into feat/tips-enterance Apr 22, 2022
@UncleBill UncleBill deleted the fix/tips-setting branch April 22, 2022 15:01
BillySh1 added a commit that referenced this pull request Apr 24, 2022
@BillySh1 @nuanyang233
@guanbinrui @septs @Jack-Works @zhouhanseng @UncleBill
feat: tips entrance (#6012)
6c6b28f 
* feat: upgrade mask wallet setting page

* feat: tips enterence init

* feat: dialog

* feat: injected dialog suppose actions badge

* feat: temp

* feat: tips wallet ui

* fix: fix

* fix: temp

* feat: popup bottom navigator

* feat: new header for popup

* fix: adjust header for ssr

* fix: build error

* fix: prettier

* refactor: split smart and dumb component

* fix: bugfix

* fix: icon

* feat: bodyviews

* fix: sth wrong

* fix: fix sth

* feat: ui

* fix: bugfix

* fix: fix

* fix: default ui

* fix: bugfix

* feat: new persona page

* fix: bugfix

* fix: bugfix

* fix: bugfix

* fix: network icon

* fix: bugfix

* fix: bugfix for header

* fix: build error

* feat: popup nextid (#6028)

* feat: compo steps init

* fix: ui

* fix: fix

* fix: kill unused code

* feat: slient sign

* fix: fix

* fix: fix

* feat: connect wallet page

* fix: typo

* fix: typo

* fix: comment

* refactor: temp

* refactor: refact steps compo

* fix: fix

Co-authored-by: nuanyang233 <nuanyang233@gmail.com>

* feat: connect wallet with persona

* fix: empty com

* fix: wallet list

* fix: wallet interface

* feat: connect popup wallet (#6081)

* feat: impl the connect page

* refactor: replace mm logo

* fix: kv temp

* fix: bugfix

* fix: bugfix

* fix: reply to commnts

* fix: typo

* fix: typo again

* chore: improve eslint (#6084)

* chore: improve eslint

* revert: file

* fix: eslintrc

* chore: setup i18n in background (#6086)

* fix: revert remove i18n key

* fix: remove wallet sign

* fix: temp

* feat: popup connect wallet (#6088)

* fix: personalSign

* refactor: replace NetworkType with ChainId

* fix: popup connect wallet

* fix: bugfix

* feat: popup custom snackbar

* fix: eslint

* fix: fix

* fix: delete unused code

* fix: ui

* refactor: move verify wallet to persona

* fix: navigate replace

* fix: ui issues

* fix: refresh proofs when bound

* fix: conflict

* fix: fix

* Delete settings.json

* fix: vscode settings

* fix: temp

* fix: types

* fix: wallet dialog

* fix: set as default

* fix: typo

* fix: sth

* feat: switch

* feat: disconnect dialog

* fix: disconnect

* chore: ui style

* fix: persona max length

* fix: fix

* fix: persona max length

* chore: reply review

* fix: i18n init twice in wrong context

* feat: add loading at connected wallets page

* fix: temp

* fix: reply to coments

* fix: locales

* fix: kill !evm

* fix: disable open new window when sign on popup

* fix: pos

* fix: replace

* fix: steps btn loading

* fix: navigate back when wallet sign success

* refactor: replace useState to useAsyncFn

* fix: adjust connect wallet step

* fix: err state

* fix: go back when wallet signed

* fix: temp

* fix: ui

* fix:  wallet name

* fix: bugfix

* fix: sign

* fix: sign step

* fix: fix

* fix: sth

* fix: fix

* chore: tips no wallet connected required

* fix: fix bug

* chore: tips jump to next id

* fix: fix

* fix: sign text

* fix: ens

* fix: disable when not in evm

* fix: ui temp

* fix: temp

* fix: ui

* fix: empty status

* fix: fix address crash

* fix: add && del fix

* fix: confirm bug

* fix: fix

* fix: some ui issues

* fix: change icon

* fix: temp

* fix: icon

* fix: del wlt&& un unsed code

* fix: kv storage

* fix: reply temp

* fix: temp

* fix: fix

* style: judge

* fix: lint err

* fix: verify

* feat: only evm

* fix: only evm fix

* fix: sth

* fix: sort

* style: kill console

* fix: kv

* fix: lint

* fix: sort fix

* chore: disable tips entry as no nextId

* style: debug

* fix: kill prividerdespecter

* chore: remove useless interface

* fix: fix

* fix: kill unused type

* fix: discard unrelated changes

* chore: add config

* fix: wallet name idx

* fix: reverse

* fix: steps wallet name

* fix: wallet name sign fix

* style: reply

* fix: new idx

* fix: wallet name sort

* fix: typo

* fix: optimise change default speed

* fix: locales

* chore: handle sns persona unmatched

* chore: move verify logic out of tips

* chore: rename

* style: reply to cmt

* Update packages/mask/src/plugins/Tips/SNSAdaptor/TipsEntranceDialog.tsx

Co-authored-by: UncleBill <billbill290@gmail.com>

* fix: for review

* fix: name

* chore: reply code review

* fix: typo

* fix: name fix

* style: reply to comments

* Update packages/shared-base/src/NextID/type.ts

Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>

* fix: resolve issues

* Update packages/mask/src/components/shared/ApplicationBoard.tsx

Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>

* fix: review

* fix: types

* fix: reply

* fix: reply

* fix(tips): some improvement (#6129)

* fix: fix

* style: reply to comments

* refactor: refact the useTipsWalletsList

* fix: build

* fix: types

* fix: build empty component

* chore: reply code review

* chore: reply code review

Co-authored-by: nuanyang233 <nuanyang233@gmail.com>
Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
Co-authored-by: septs <github@septs.pw>
Co-authored-by: Jack Works <jackworks@protonmail.com>
Co-authored-by: zhouhanseng <z308114274@gmail.com>
Co-authored-by: UncleBill <billbill290@gmail.com>
@Jsn2win Jsn2win mentioned this pull request Nov 28, 2023
Open
This was referenced Mar 22, 2024
Open
Open
@yisiliu yisiliu mentioned this pull request Mar 24, 2024
Closed
@yisiliu yisiliu mentioned this pull request Apr 18, 2024
Closed
This was referenced Oct 16, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@UncleBill