Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HashRouter in the SNS Adaptor #6135

Closed
Jack-Works opened this issue Apr 24, 2022 · 2 comments · Fixed by #6141
Closed

Remove HashRouter in the SNS Adaptor #6135

Jack-Works opened this issue Apr 24, 2022 · 2 comments · Fixed by #6141

Comments

@Jack-Works
Copy link
Member

Wait, this does not look right. Why you're adding HashRouter in the SNS Adaptor? That's definitely wrong.

Originally posted by @Jack-Works in #5986 (comment)

cc @guanbinrui
@guanbinrui
Copy link
Member

Already removed.

@Jack-Works
Copy link
Member Author

Where? It still in the main branch

@guanbinrui guanbinrui mentioned this issue Apr 24, 2022
Merged
5 tasks
@guanbinrui guanbinrui reopened this Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove hash router DimensionDev/Maskbook
2 participants
@Jack-Works @guanbinrui