Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyManager does not follow architecture #183

Open
2 tasks
MJHC opened this issue Jan 22, 2025 · 0 comments
Open
2 tasks

KeyManager does not follow architecture #183

MJHC opened this issue Jan 22, 2025 · 0 comments
Labels
server A feature for the server component

Comments

@MJHC
Copy link
Contributor

MJHC commented Jan 22, 2025

KeyManager should not concern it self with HTTP implementations and handling, this should be in its own handler function.

  • It checks for auth on AuthenticatedDevice this is already handled by axum
  • Signal responds with null entries when keys are not found and not internal errors
@MJHC MJHC added the server A feature for the server component label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
server A feature for the server component
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MJHC