Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Alpine to 3.2.0 and handle API key migration #4566

Merged
merged 10 commits into from
Feb 10, 2025

Conversation

Gepardgame
Copy link
Contributor

@Gepardgame Gepardgame commented Jan 20, 2025

Description

Bumps Alpine to 3.2.0, here mainly adding migration for hashed api-keys

Addressed Issue

Additional Details

Checklist

  • I have read and understand the contributing guidelines
    - [ ] This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@Gepardgame Gepardgame marked this pull request as draft January 20, 2025 13:49
@Gepardgame Gepardgame force-pushed the feat/upgrade-alpine branch 2 times, most recently from 09d9fc4 to 5e1a5d8 Compare February 3, 2025 13:44
Copy link

codacy-production bot commented Feb 4, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d73d4e7) 23103 18541 80.25%
Head commit (bf8fc68) 23114 (+11) 18552 (+11) 80.26% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4566) 22 22 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Gepardgame Gepardgame marked this pull request as ready for review February 4, 2025 09:32
@nscuro nscuro added the enhancement New feature or request label Feb 4, 2025
@nscuro nscuro added this to the 4.13 milestone Feb 4, 2025
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gepardgame, really good work!

Would you mind also updating this part of the docs (i.e. the screenshot)?

Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Signed-off-by: Thomas Schauer-Koeckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
@nscuro nscuro merged commit 04c6761 into DependencyTrack:master Feb 10, 2025
11 checks passed
@nscuro nscuro changed the title Bump alpine from 3.1.2 to 3.2.0 Bump Alpine to 3.2.0 and handle API key migration Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants