Skip to content

Commit

Permalink
refactor(snap): remove interface to local filesystem and allow config…
Browse files Browse the repository at this point in the history
… to be inside snap environment
  • Loading branch information
sheldonhull committed Jan 6, 2023
1 parent 3c31950 commit 3456363
Show file tree
Hide file tree
Showing 3 changed files with 52 additions and 10 deletions.
17 changes: 17 additions & 0 deletions .changes/v1.39.13.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
## v1.39.13 - 2023-01-06

No user facing impact.
This release is iterating on Snap installation method for Linux (which is in progress), and does not impact functionality of the dsv-cli.

### 🔨 Refactor

- Remove plugs for the dsv-cli snap installation, allowing all configuration to sit inside the isolated snap environment.

### Related

- fixes AB#480396
- related AB#464526

### Contributors

- [sheldonhull](https://github.com/sheldonhull)
27 changes: 17 additions & 10 deletions .goreleaser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,21 @@ snapcrafts:
apps:
# The name of the app must be the same name as the binary built or the snapcraft name.
dsv-cli:
plugs: ['home', 'network'] # might need personal-files for storing in dotfile directory
# https://snapcraft.io/docs/home-interface
plugs: ['network'] # removed home, and personal-files as these would persist outside the snap but require special approval. Instead all the data will be contained the snap environment itself.
command: dsv
# aliases: ['dsv']
plugs:
personal-files:
read:
- $HOME/.dsv.yml
- $HOME/.thy
write:
- $HOME/.dsv.yml
- $HOME/.thy

# SNAP DOCS:
# https://snapcraft.io/docs/environment-variables
# For non-classic snaps, this environment variable is re-written to SNAP_USER_DATA by snapd so that each snap appears to have a dedicated home directory that is a subdirectory of the real home directory.
# args: --config 'SNAP_USER_COMMON/.dsv.yml'
# aliases: ['dsv']
# as a result, no plugs for home should be required
# plugs:
# personal-files:
# read:
# - $HOME/.dsv.yml
# - $HOME/.thy
# write:
# - $HOME/.dsv.yml
# - $HOME/.thy
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,24 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html),
and is generated by [Changie](https://github.com/miniscruff/changie).

## v1.39.13 - 2023-01-06

No user facing impact.
This release is iterating on Snap installation method for Linux (which is in progress), and does not impact functionality of the dsv-cli.

### 🔨 Refactor

- Remove plugs for the dsv-cli snap installation, allowing all configuration to sit inside the isolated snap environment.

### Related

- fixes AB#480396
- related AB#464526

### Contributors

- [sheldonhull](https://github.com/sheldonhull)

## v1.39.12 - 2023-01-05

No user facing impact.
Expand Down

0 comments on commit 3456363

Please sign in to comment.