From b8d0aa639a9e7627fa34e2a71537f64d2c57b2ec Mon Sep 17 00:00:00 2001 From: Manuel Sommer Date: Sat, 8 Feb 2025 22:31:49 +0100 Subject: [PATCH 1/2] Return Feedback about wrong File Format in ZAP --- dojo/tools/zap/parser.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dojo/tools/zap/parser.py b/dojo/tools/zap/parser.py index 19fbf16241e..0cb75feb738 100644 --- a/dojo/tools/zap/parser.py +++ b/dojo/tools/zap/parser.py @@ -27,6 +27,8 @@ def get_description_for_scan_types(self, scan_type): return "ZAP XML report format." def get_findings(self, file, test): + if not file.name.endswith(".xml"): + raise ValueError("Internal error: Wrong file format, please use xml.") tree = ET.parse(file) items = [] for node in tree.findall("site"): From 407fb2f1321b5566cf807b6c6163ae9799390731 Mon Sep 17 00:00:00 2001 From: Manuel Sommer Date: Sat, 8 Feb 2025 22:35:06 +0100 Subject: [PATCH 2/2] ruff --- dojo/tools/zap/parser.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dojo/tools/zap/parser.py b/dojo/tools/zap/parser.py index 0cb75feb738..88d09ccb66e 100644 --- a/dojo/tools/zap/parser.py +++ b/dojo/tools/zap/parser.py @@ -28,7 +28,8 @@ def get_description_for_scan_types(self, scan_type): def get_findings(self, file, test): if not file.name.endswith(".xml"): - raise ValueError("Internal error: Wrong file format, please use xml.") + msg = "Internal error: Wrong file format, please use xml." + raise ValueError(msg) tree = ET.parse(file) items = [] for node in tree.findall("site"):