Skip to content

Commit 1611e86

Browse files
committed
edited README.md to
1 parent 1961595 commit 1611e86

15 files changed

+52
-27
lines changed

README.md

+47-26
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ This is a solution to the [Newsletter sign-up form with success message challeng
1616
- [Author](#author)
1717
- [Acknowledgments](#acknowledgments)
1818

19-
**Note: Delete this note and update the table of contents based on what sections you keep.**
20-
2119
## Overview
2220

2321
### The challenge
@@ -32,25 +30,51 @@ Users should be able to:
3230
- View the optimal layout for the interface depending on their device's screen size
3331
- See hover and focus states for all interactive elements on the page
3432

35-
### Screenshot
36-
37-
![](./assets/images/desktop_error_screen.png)
38-
![](./assets/images/desktop)
39-
![](./assets/images/desktop_error_screen.png)
40-
41-
42-
Add a screenshot of your solution. The easiest way to do this is to use Firefox to view your project, right-click the page and select "Take a Screenshot". You can choose either a full-height screenshot or a cropped one based on how long the page is. If it's very long, it might be best to crop it.
43-
44-
Alternatively, you can use a tool like [FireShot](https://getfireshot.com/) to take the screenshot. FireShot has a free option, so you don't need to purchase it.
45-
46-
Then crop/optimize/edit your image however you like, add it to your project, and update the file path in the image above.
47-
48-
**Note: Delete this note and the paragraphs above when you add your screenshot. If you prefer not to add a screenshot, feel free to remove this entire section.**
33+
### Screenshots
34+
<figure style="width:35%">
35+
<img src="./assets/images/mobile-screen.png" width="">
36+
<figcaption style="text-transform:Capitalize; background:rgba(255,255,255,0.1); padding: 8px">mobile screen</figcaption>
37+
</figure>
38+
<br>
39+
<figure style="width:35%">
40+
<img src="./assets/images/mobile-screen-success.png" width="">
41+
<figcaption style="text-transform:Capitalize; background:rgba(255,255,255,0.1); padding: 8px">mobile success screen</figcaption>
42+
</figure>
43+
<br>
44+
<figure>
45+
<img src="./assets/images/desktop-screen.png" width="100%">
46+
<figcaption style="text-transform:Capitalize; background:rgba(255,255,255,0.1); padding: 8px">desktop screen</figcaption>
47+
</figure>
48+
<br>
49+
<figure>
50+
<img src="./assets/images/desktop-screen-succes.png" width="100%">
51+
<figcaption style="text-transform:Capitalize; background:rgba(255,255,255,0.1); padding: 8px">desktop success screen</figcaption>
52+
</figure>
53+
<br>
54+
<figure style="width:100%">
55+
<img src="./assets/images/error-1.png" width="100%">
56+
<figcaption style="text-transform:Capitalize; background:rgba(255,0,0,0.1); padding: 8px">invalid email error</figcaption>
57+
</figure>
58+
<br>
59+
<figure style="width:100%">
60+
<img src="./assets/images/error-2.png" width="100%">
61+
<figcaption style="text-transform:Capitalize; background:rgba(255,0,0,0.1); padding: 8px">input field error</figcaption>
62+
</figure>
63+
<br>
64+
<figure style="width:100%">
65+
<img src="./assets/images/active-state-2.png" width="100%">
66+
<figcaption style="text-transform:Capitalize; background:rgba(0,255,0,0.1); padding: 8px">input field active</figcaption>
67+
</figure>
68+
<br>
69+
<figure style="width:100%">
70+
<img src="./assets/images/active-state-1.png" width="100%">
71+
<figcaption style="text-transform:Capitalize; background:rgba(0,255,0,0.1); padding: 8px">button active</figcaption>
72+
</figure>
4973

5074
### Links
5175

52-
- Solution URL: [Add solution URL here](https://your-solution-url.com)
53-
- Live Site URL: [Add live site URL here](https://your-live-site-url.com)
76+
- Solution URL: [Repo](https://github.com/Deeokafor/fm-newsletter-sign-up-with-success-message-main)
77+
- Live Site URL: [https://github.com/Deeokafor/fm-newsletter-sign-up-with-success-message-main](https://github.com/Deeokafor/fm-newsletter-sign-up-with-success-message-main)
5478

5579
## My process
5680

@@ -70,17 +94,14 @@ Then crop/optimize/edit your image however you like, add it to your project, and
7094

7195
### Continued development
7296

73-
Use this section to outline areas that you want to continue focusing on in future projects. These could be concepts you're still not completely comfortable with or techniques you found useful that you want to refine and perfect.
74-
75-
**Note: Delete this note and the content within this section and replace with your own plans for continued development.**
76-
97+
Henceforth, I am focusing on writing UI's which pass accessibilty tests and Semantic-ui's.
7798
### Useful resources
7899

79-
- [w3docs](https://www.w3docs.com) - Their tutorial on adjusting the positions of custom list styles was helpful. You can check it out at [How to Adjust the Position of List Style Image](https://www.w3docs.com/snippets/css/how-to-adjust-the-position-of-list-style-image.html)
100+
- [Tailwindcss Docs](https://www.tailwindcss.com) - having to refer to the detailed docs here when in a tight spot was so helpful.
101+
102+
- [w3schools](https://www.w3schools.com/cssref/css3_pr_align-self.php) - At some point in the project, I was stumped with properly aligning the elements for the `mobile-success-screen` but a little bit of practise on `align-self` rules in css, here, helped me to overcame that challenge in Tailwindcss.
80103

81-
- [css-tricks](https://css-tricks.com/quick-reminder-about-file-paths/) - Their short tutorial on fixed and relative filepaths was super helpful in debugging a file path issue I had with Tailwindcss. You can check it out at [Quick Reminder About File Paths](https://css-tricks.com/quick-reminder-about-file-paths/)
82104

83-
- [github mkdocs](https://github.com/mkdocs/mkdocs/issues/1757) - the discussions held by these helpful fellows on how github pages using the MkDocs handles file paths in production was super helpful to debug my path failure issues. You can check them out at [ Image paths can break when deploying to gh-pages #1757 ](https://github.com/mkdocs/mkdocs/issues/1757)
84105

85106

86107
## Author
@@ -91,4 +112,4 @@ Use this section to outline areas that you want to continue focusing on in futur
91112

92113
## Acknowledgments
93114

94-
- I am thankful to []().
115+
- I am thankful to [Google Search](google.com) :).

assets/css/output.css

+4
Original file line numberDiff line numberDiff line change
@@ -840,6 +840,10 @@ video {
840840
padding-top: 1.5rem;
841841
}
842842

843+
.tw-pb-10 {
844+
padding-bottom: 2.5rem;
845+
}
846+
843847
.tw-text-center {
844848
text-align: center;
845849
}

assets/images/active-state-1.png

219 KB
Loading

assets/images/active-state-2.png

550 KB
Loading
177 KB
Loading

assets/images/desktop-screen.png

500 KB
Loading
-514 KB
Binary file not shown.

assets/images/desktop_screen.png

-509 KB
Binary file not shown.
-177 KB
Binary file not shown.

assets/images/error-1.png

551 KB
Loading

assets/images/error-2.png

552 KB
Loading
91.5 KB
Loading
Loading
-88.7 KB
Binary file not shown.

index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ <h1 class="tw-text-[2.55rem] tw-font-extrabold lg:tw-text-[3.5rem]">Stay updated
4949

5050
<!-- Modal -->
5151
<div id="modal" class="tw-hidden lg:tw-text-[14px]">
52-
<div class="tw-min-h-screen tw-px-8 tw-pb-8 tw-flex tw-flex-wrap tw-items-start lg:tw-bg-white lg:tw-w-[26rem] lg:tw-min-h-[26rem] lg:tw-rounded-[1.9rem] lg:tw-p-12">
52+
<div class="tw-min-h-screen tw-px-8 tw-pb-10 tw-flex tw-flex-wrap tw-items-start lg:tw-bg-white lg:tw-w-[26rem] lg:tw-min-h-[26rem] lg:tw-rounded-[1.9rem] lg:tw-p-12">
5353
<div class="tw-text-ns-dsg tw-self-end">
5454
<div class="tw-mb-3"><img src="./assets/images/icon-success.svg" alt="" class=""></div>
5555
<h1 class="tw-text-[2.50rem] tw-leading-[2.55rem] tw-font-black tw-py-7">Thanks for subscribing!</h1>

0 commit comments

Comments
 (0)