Added config to not collect default JVM metrics (#345)

gh123man · web-flow · commit f4237dbc78cb · 2020-12-11T09:02:15.000-05:00
* added flag to not collect default JVM metrics

* cleanup log line
diff --git a/src/main/java/org/datadog/jmxfetch/Instance.java b/src/main/java/org/datadog/jmxfetch/Instance.java
@@ -224,8 +224,13 @@ public Instance(
             }
         }
 
-        loadDefaultConfig("default-jmx-metrics.yaml");
-        loadDefaultConfig(gcMetricConfig);
+        Boolean collectDefaultJvmMetrics = (Boolean) instanceMap.get("collect_default_jvm_metrics");
+        if (collectDefaultJvmMetrics == null || collectDefaultJvmMetrics) {
+            loadDefaultConfig("default-jmx-metrics.yaml");
+            loadDefaultConfig(gcMetricConfig);
+        } else {
+            log.info("collect_default_jvm_metrics is false - not collecting default JVM metrics");
+        }
     }
 
     public static boolean isDirectInstance(Map<String, Object> configInstance) {

Original file line number	Diff line number	Diff line change
`@@ -224,8 +224,13 @@ public Instance(`
`224`	`224`	`}`
`225`	`225`	`}`
`226`	`226`
`227`		`- loadDefaultConfig("default-jmx-metrics.yaml");`
`228`		`- loadDefaultConfig(gcMetricConfig);`
	`227`	`+ Boolean collectDefaultJvmMetrics = (Boolean) instanceMap.get("collect_default_jvm_metrics");`
	`228`	`+ if (collectDefaultJvmMetrics == null \|\| collectDefaultJvmMetrics) {`
	`229`	`+ loadDefaultConfig("default-jmx-metrics.yaml");`
	`230`	`+ loadDefaultConfig(gcMetricConfig);`
	`231`	`+ } else {`
	`232`	`+ log.info("collect_default_jvm_metrics is false - not collecting default JVM metrics");`
	`233`	`+ }`
`229`	`234`	`}`
`230`	`235`
`231`	`236`	`public static boolean isDirectInstance(Map<String, Object> configInstance) {`