Skip to content

Commit 59fd1f1

Browse files
Merge pull request #322 from richardstartin/rgs/remove-commons-io
Remove commons io
2 parents d7e2966 + 2306f77 commit 59fd1f1

File tree

3 files changed

+17
-10
lines changed

3 files changed

+17
-10
lines changed

pom.xml

-5
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,6 @@
8383
<scope>system</scope>
8484
<systemPath>${java.home}/../lib/tools.jar</systemPath>
8585
</dependency>
86-
<dependency>
87-
<groupId>commons-io</groupId>
88-
<artifactId>commons-io</artifactId>
89-
<version>${commons-io.version}</version>
90-
</dependency>
9186
<dependency>
9287
<groupId>com.datadoghq</groupId>
9388
<artifactId>java-dogstatsd-client</artifactId>

src/main/java/org/datadog/jmxfetch/App.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import com.beust.jcommander.ParameterException;
77
import com.fasterxml.jackson.core.JsonProcessingException;
88
import lombok.extern.slf4j.Slf4j;
9-
import org.apache.commons.io.IOUtils;
109
import org.apache.logging.log4j.Level;
1110
import org.apache.logging.log4j.LogManager;
1211

@@ -780,8 +779,8 @@ private boolean getJsonConfigs() {
780779
log.debug("No configuration changes...");
781780
return update;
782781
}
783-
784-
InputStream jsonInputStream = IOUtils.toInputStream(response.getResponseBody(), UTF_8);
782+
byte[] utf8 = response.getResponseBody().getBytes(UTF_8);
783+
InputStream jsonInputStream = new ByteArrayInputStream(utf8);
785784
JsonParser parser = new JsonParser(jsonInputStream);
786785
int timestamp = ((Integer) parser.getJsonTimestamp()).intValue();
787786
if (timestamp > lastJsonConfigTs) {

src/main/java/org/datadog/jmxfetch/Status.java

+15-2
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@
22

33
import com.fasterxml.jackson.jr.ob.JSON;
44
import lombok.extern.slf4j.Slf4j;
5-
import org.apache.commons.io.FileUtils;
65
import org.yaml.snakeyaml.Yaml;
76

7+
import java.io.BufferedOutputStream;
88
import java.io.File;
9+
import java.io.FileOutputStream;
910
import java.io.IOException;
11+
import java.nio.charset.Charset;
1012
import java.util.ArrayList;
1113
import java.util.HashMap;
1214
import java.util.List;
@@ -147,7 +149,7 @@ public void flush() {
147149
File statusFile = new File(this.statusFileLocation);
148150
log.debug(
149151
"Writing status to temp yaml file: " + statusFile.getAbsolutePath());
150-
FileUtils.writeStringToFile(statusFile, yaml);
152+
writeStringToFile(statusFile, yaml);
151153
} catch (Exception e) {
152154
log.warn("Cannot write status to temp file: " + e.getMessage());
153155
}
@@ -164,4 +166,15 @@ public String getStatusFileLocation() {
164166
public boolean isEnabled() {
165167
return isEnabled;
166168
}
169+
170+
private static void writeStringToFile(File file, String string) throws IOException {
171+
FileOutputStream out = new FileOutputStream(file);
172+
BufferedOutputStream bos = new BufferedOutputStream(out);
173+
try {
174+
bos.write(string.getBytes(Charset.forName("UTF-8")));
175+
} finally {
176+
bos.close();
177+
out.close();
178+
}
179+
}
167180
}

0 commit comments

Comments
 (0)