Reduce log verbosity level for unverified HTTP requests. (#19791)

* Reduce log verbosity level for unverified HTTP requests.

* add changelog

Author: iliakur

datadog_checks_base/changelog.d/19791.fixed

@@ -0,0 +1 @@
+Reduce log verbosity level for unverified HTTP requests. WARNING level spams a lot with no evidence that users pay attention. DEBUG will be useful for support cases.

datadog_checks_base/datadog_checks/base/checks/prometheus/mixins.py

@@ -569,7 +569,7 @@ def poll(self, endpoint, pFormat=PrometheusFormat.PROTOBUF, headers=None, instan
             and not handler.ignore_tls_warning
             and not is_affirmative(handler.options.get('ssl_verify', True))
         ):
-            self.log.warning(u'An unverified HTTPS request is being made to %s', endpoint)
+            self.log.debug(u'An unverified HTTPS request is being made to %s', endpoint)
 
         try:
             response = handler.get(endpoint, extra_headers=headers, stream=False)

datadog_checks_base/datadog_checks/base/utils/http.py

@@ -394,7 +394,7 @@ def _request(self, method, url, options):
         new_options = self.populate_options(options)
 
         if url.startswith('https') and not self.ignore_tls_warning and not new_options['verify']:
-            self.logger.warning(u'An unverified HTTPS request is being made to %s', url)
+            self.logger.debug(u'An unverified HTTPS request is being made to %s', url)
 
         extra_headers = options.pop('extra_headers', None)
         if extra_headers is not None:

datadog_checks_base/tests/base/utils/http/test_tls_and_certs.py

@@ -76,10 +76,10 @@ def test_default_no_ignore(self, caplog):
 
         expected_message = 'An unverified HTTPS request is being made to https://www.google.com'
         for _, level, message in caplog.record_tuples:
-            if level == logging.WARNING and message == expected_message:
+            if level == logging.DEBUG and message == expected_message:
                 break
         else:
-            raise AssertionError('Expected WARNING log with message `{}`'.format(expected_message))
+            raise AssertionError('Expected DEBUG log with message `{}`'.format(expected_message))
 
     def test_default_no_ignore_http(self, caplog):
         instance = {}
@@ -113,10 +113,10 @@ def test_default_no_ignore_session(self, caplog):
 
         expected_message = 'An unverified HTTPS request is being made to https://www.google.com'
         for _, level, message in caplog.record_tuples:
-            if level == logging.WARNING and message == expected_message:
+            if level == logging.DEBUG and message == expected_message:
                 break
         else:
-            raise AssertionError('Expected WARNING log with message `{}`'.format(expected_message))
+            raise AssertionError('Expected DEBUG log with message `{}`'.format(expected_message))
 
     def test_ignore_session(self, caplog):
         instance = {'tls_ignore_warning': True, 'persist_connections': True}
@@ -152,10 +152,10 @@ def test_default_init_no_ignore(self, caplog):
 
         expected_message = 'An unverified HTTPS request is being made to https://www.google.com'
         for _, level, message in caplog.record_tuples:
-            if level == logging.WARNING and message == expected_message:
+            if level == logging.DEBUG and message == expected_message:
                 break
         else:
-            raise AssertionError('Expected WARNING log with message `{}`'.format(expected_message))
+            raise AssertionError('Expected DEBUG log with message `{}`'.format(expected_message))
 
     def test_instance_ignore(self, caplog):
         instance = {'tls_ignore_warning': True}
@@ -179,10 +179,10 @@ def test_instance_no_ignore(self, caplog):
 
         expected_message = 'An unverified HTTPS request is being made to https://www.google.com'
         for _, level, message in caplog.record_tuples:
-            if level == logging.WARNING and message == expected_message:
+            if level == logging.DEBUG and message == expected_message:
                 break
         else:
-            raise AssertionError('Expected WARNING log with message `{}`'.format(expected_message))
+            raise AssertionError('Expected DEBUG log with message `{}`'.format(expected_message))
 
 
 class TestAIAChasing: