Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP multiplexing #953

Merged
merged 5 commits into from
Mar 27, 2020
Merged

Add HTTP multiplexing #953

merged 5 commits into from
Mar 27, 2020

Conversation

delner
Copy link
Contributor

@delner delner commented Feb 19, 2020

As a PR that replaces #882 (incorporating @stormsilver's original contributions; thank you!), this pull request aims to add "multiplexing" to the other HTTP client libraries instrumented.

In practice, "multiplexing" allows users to configure different tracer settings for different URLs. The most common reason why you might prefer to do this is to mark some outgoing HTTP calls as belonging to one service, while marking others as belonging to another.

e.g.

Datadog.configure do |c|
 # Assign all outgoing Net::HTTP requests to amazonaws.com to the 'aws' service
  c.use :http, describe: /amazonaws\.com/ do |http|
    http.service_name = 'aws'
  end
end

It also adds split_by_domain options which assigns the FQDN of the request URL as the service name.

These changes affect the following libraries:

  • Ethon
  • Excon
  • Faraday
  • HTTP

@delner delner added integrations Involves tracing integrations community Was opened by a community member feature Involves a product feature labels Feb 19, 2020
@delner delner requested review from marcotc and a team February 19, 2020 22:32
@delner delner self-assigned this Feb 19, 2020
@delner
Copy link
Contributor Author

delner commented Feb 19, 2020

Changes are working, but might want to do a little refactoring/testing before merging. Could use a review from you as well @marcotc.

Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good overall! 👍

@delner delner force-pushed the feature/http_multiplexing branch from c933340 to 48856af Compare March 27, 2020 21:14
@delner delner added this to the 0.34.0 milestone Mar 27, 2020
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@delner delner merged commit 069cb0e into master Mar 27, 2020
@delner delner deleted the feature/http_multiplexing branch March 27, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member feature Involves a product feature integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants