-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP multiplexing #953
Conversation
Changes are working, but might want to do a little refactoring/testing before merging. Could use a review from you as well @marcotc. |
856c6d2
to
c933340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very good overall! 👍
c933340
to
48856af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
As a PR that replaces #882 (incorporating @stormsilver's original contributions; thank you!), this pull request aims to add "multiplexing" to the other HTTP client libraries instrumented.
In practice, "multiplexing" allows users to configure different tracer settings for different URLs. The most common reason why you might prefer to do this is to mark some outgoing HTTP calls as belonging to one service, while marking others as belonging to another.
e.g.
It also adds
split_by_domain
options which assigns the FQDN of the request URL as the service name.These changes affect the following libraries: