[k8s] Update library, allow deployment API to fail #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The latest version of the library includes better logging for errors which include the status code. See ericchiang/k8s#58 * The deployment API is unavailable in older versions of Kubernetes. We don't really _need_ this information since we can parse it from the ReplicaSet name.
|
|
|
Tests are failing for a known issue, a fix is on the way |
masci
suggested changes
Oct 12, 2017
| return nil, fmt.Errorf("failed to get deployments: %s", err) | ||
| // Allow Deployments API to fail, it's not available in all version and we | ||
| // can also parse this data from the replica-set name on the backend. | ||
| log.Warnf("Failed to retrieve Kubernetes deployments: %s", err) |
There was a problem hiding this comment.
didn't notice but log package was not imported
masci
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update k8s library, allow deployment API to fail.
which include the status code. See Include statusCode when failure to unmarshal ericchiang/k8s#58
don't really need this information since we can parse it from the
ReplicaSet name.
Motivation
We've had a couple users (https://trello.com/c/5VjK5smo/560-braintree-having-trouble-with-custom-api-server-port-for-kubernetes, https://trello.com/c/gMllhQNi/605-k8-side-bar-filters) who hit an error in deployments API. Right now the first case at least ended up being an issue with missing RBAC configuration. The update to the library should provide some additional context here.