Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use agent version instead of agent status to determine the current Agent version #852

Merged
merged 11 commits into from
Jul 13, 2022
Merged

Use agent version instead of agent status to determine the current Agent version #852

merged 11 commits into from
Jul 13, 2022

Conversation

amenasria
Copy link
Contributor

Here we call agent status, which does an http request to the running Agent.

If the Agent is misbehaving, agent status might take a long time to return.

This PR replaces this with agent version which returns immediately.

@amenasria amenasria requested a review from a team as a code owner June 27, 2022 11:56
@amenasria amenasria marked this pull request as draft June 27, 2022 12:58
@amenasria amenasria marked this pull request as ready for review July 11, 2022 15:18
@amenasria amenasria merged commit e77a6c3 into main Jul 13, 2022
@amenasria amenasria deleted the amenasria/use-version-instead-of-status branch July 13, 2022 09:48
@jeffbyrnes jeffbyrnes mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

Assignees
No one assigned
Labels
optimize
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amenasria @mx-psi