Prevent writing of different ressources.list files with same content … #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSerrania
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Hi @nilskuehme,
Thanks for the report and the PR!
That's indeed a bug, we don't want to have multiple list files with the same content.
Since we do want to install both keys, we'll also have to find another way to install the other key before releasing a new version of the cookbook.
This PR looks good to me.
|
Hi @KSerrania , thank you for confirmation. I have seen your approval but unfortunately i'm not able to merge. Is this something you can do? |
nilskuehme
deleted the
prevent-writing-of-different-ressources.listfiles-with-same-content-in-debian
branch
|
Great, thank you very much 👍 |
KSerrania
added a commit
that referenced
this pull request
Dec 9, 2020
Re-introduces the install of the new apt signing key D75CEA17048B9ACBF186794B32637D44F14F620E, removed in #761 because of a bug. Cleans up superfluous repository files that may have been added by versions 4.7.0 and 4.7.2 of the cookbook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in debian
It turned out that the changes made in #757 created new files in /etc/apt/sources.list.d/ called
datadog_apt_A2923DFF56EDA6E76E55E492D3A80E30382E94DE.listanddatadog_apt_D75CEA17048B9ACBF186794B32637D44F14F620E.listwith the same content. This will cause the following warning message to appear each time an apt update is run:W: Target Packages (7/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_A2923DFF56EDA6E76E55E492D3A80E30382E94DE.list:1 W: Target Packages (7/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_A2923DFF56EDA6E76E55E492D3A80E30382E94DE.list:1 W: Target Translations (7/i18n/Translation-en_US) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_A2923DFF56EDA6E76E55E492D3A80E30382E94DE.list:1 W: Target Translations (7/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_A2923DFF56EDA6E76E55E492D3A80E30382E94DE.list:1 W: Target Packages (7/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_D75CEA17048B9ACBF186794B32637D44F14F620E.list:1 W: Target Packages (7/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_D75CEA17048B9ACBF186794B32637D44F14F620E.list:1 W: Target Translations (7/i18n/Translation-en_US) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_D75CEA17048B9ACBF186794B32637D44F14F620E.list:1 W: Target Translations (7/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_D75CEA17048B9ACBF186794B32637D44F14F620E.list:1 W: Target Packages (7/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_A2923DFF56EDA6E76E55E492D3A80E30382E94DE.list:1 W: Target Packages (7/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_A2923DFF56EDA6E76E55E492D3A80E30382E94DE.list:1 W: Target Translations (7/i18n/Translation-en_US) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_A2923DFF56EDA6E76E55E492D3A80E30382E94DE.list:1 W: Target Translations (7/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_A2923DFF56EDA6E76E55E492D3A80E30382E94DE.list:1 W: Target Packages (7/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_D75CEA17048B9ACBF186794B32637D44F14F620E.list:1 W: Target Packages (7/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_D75CEA17048B9ACBF186794B32637D44F14F620E.list:1 W: Target Translations (7/i18n/Translation-en_US) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_D75CEA17048B9ACBF186794B32637D44F14F620E.list:1 W: Target Translations (7/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/datadog.list:1 and /etc/apt/sources.list.d/datadog_apt_D75CEA17048B9ACBF186794B32637D44F14F620E.list:1apt update runs through, but it doesn't make sense to me why there should be multiple files with the same mirror specifications as content. To add multiple apt keys it's needed to use the apt-repository resource in Chef. The resource automatically wants to add the sources.list.d files, which have the same content while getting added using each.do. As it looks like there is no way to add only the keys to the system without creating a file in sources.list.d (since :add is set by default) and then adding one file with the mirror content.
So it only makes sense to add a key (the one with the longer runtime) and use the file /etc/apt/sources.list.d/datadog.list again, otherwise systems using the cookbook before version 4.7.2 and then upgrading to 4.7.2 will find three files with the same content in sources.list.d:
Another advantage of using uniform file names is the scalability and thus the exchangeability of file contents, as well as the reduction of redundancies such as in file names.