Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[circlci] Add tests for Chef 16.5.77 #741

Merged
merged 8 commits into from
Oct 6, 2020
Merged

[circlci] Add tests for Chef 16.5.77 #741

merged 8 commits into from
Oct 6, 2020
+61 −107

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Oct 2, 2020

No description provided.

@truthbk truthbk requested a review from a team as a code owner October 2, 2020 18:29
@truthbk truthbk force-pushed the jaime/chef16.5 branch 2 times, most recently from a387c17 to d3e9dde Compare October 2, 2020 19:06
@albertvaka albertvaka mentioned this pull request Oct 5, 2020
Merged
truthbk and others added 5 commits October 5, 2020 12:03
@truthbk @albertvaka
[circlci] adding test for chef 16.5.77

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
e17ad37
@truthbk @albertvaka
[circlci] set correct ruby version

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
73fdf25
@truthbk @albertvaka
[circlci] must update lockfile - dirty

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
98c2b1a
@albertvaka
Remove some kitchen tests to not hit max open files limit
22a17df
@albertvaka
Added chef 16.5 to kitchen tests
0903ce2
@albertvaka albertvaka force-pushed the jaime/chef16.5 branch 2 times, most recently from 138ec5f to 193d5f6 Compare October 5, 2020 10:19
@albertvaka albertvaka force-pushed the jaime/chef16.5 branch 6 times, most recently from bd8b667 to e6c09f9 Compare October 5, 2020 10:36
@albertvaka albertvaka changed the title [circlci] adding test for chef 16.5.77 [circlci] Add tests for Chef 16.5.77 Oct 5, 2020
@albertvaka
Copy link
Contributor

I've refactored a bit the tests, because it wasn't obvious what "full-suite" meant (it just called kitchen docker tests, so there was no point on creating a copy of it for chef 16 -> instead a new entry had to be added to kitchen.docker.yaml)

truthbk
truthbk commented Oct 5, 2020
View reviewed changes
Copy link
Member Author

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@albertvaka albertvaka merged commit 4d0da7c into master Oct 6, 2020
@albertvaka albertvaka deleted the jaime/chef16.5 branch October 6, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@truthbk @albertvaka