Update README.md #639
Merged
Update README.md #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasn't able to figure out how to set nested attributes using the `extra_configs` field, so I added an example
remeh
requested changes
Sep 9, 2019
|
|
||
| For nested attributes, use object syntax: | ||
|
|
||
| E.g. |
There was a problem hiding this comment.
Good addition, I didn't know it was a problem for nested attributes and that we must use the object syntax 👍
However, what do you think of sticking with the original example and adding the nested attribute example below? I think it would be more natural to read.
There was a problem hiding this comment.
Yeah if you think reordering the addition makes sense, that's totally fine. I'm not entirely sure how you want to rearrange it though. If you want to just make another commit with your recommendation that is probably easiest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasn't able to figure out how to set nested attributes using the
extra_configsfield, took like an hour or 2 of asking around/ guess and checking, so I added an example