Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #639

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Update README.md #639

merged 2 commits into from
Sep 25, 2019

Conversation

nicholas-devlin
Copy link
Contributor

@nicholas-devlin nicholas-devlin commented Sep 3, 2019

wasn't able to figure out how to set nested attributes using the extra_configs field, took like an hour or 2 of asking around/ guess and checking, so I added an example

wasn't able to figure out how to set nested attributes using the `extra_configs` field, so I added an example
Copy link
Contributor

@remeh remeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition 👍 I've left a comment requesting your opinion.


For nested attributes, use object syntax:

E.g.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition, I didn't know it was a problem for nested attributes and that we must use the object syntax 👍
However, what do you think of sticking with the original example and adding the nested attribute example below? I think it would be more natural to read.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah if you think reordering the addition makes sense, that's totally fine. I'm not entirely sure how you want to rearrange it though. If you want to just make another commit with your recommendation that is probably easiest.

Copy link
Contributor

@remeh remeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦

@remeh remeh merged commit 3e39a36 into DataDog:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants