Skip to content

Commit 2a4708e

Browse files
authored
Merge pull request #43 from Dasaav-dsv/param-fix
Account for Smithbox paramdef RemovedVersion field
2 parents 9819207 + df5c966 commit 2a4708e

23 files changed

+23
-102
lines changed

include/param/paramdef/ASSET_GEOMETORY_PARAM_ST.hpp

+1-5
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,6 @@ struct ASSET_GEOMETORY_PARAM_ST {
217217
*/
218218
bool isAttackBacklash : 1 { true };
219219

220-
unsigned char Reserve_2 : 1;
221-
222220
/**
223221
* @brief Is it a ladder?
224222
*
@@ -899,8 +897,6 @@ struct ASSET_GEOMETORY_PARAM_ST {
899897
*/
900898
unsigned char excludeActivateRatio_PS4_Legacy{ 0 };
901899

902-
unsigned char Reserve_0_Old[32];
903-
904900
unsigned char unknown_0x120{ 0 };
905901

906902
unsigned char unknown_0x121{ 0 };
@@ -919,5 +915,5 @@ struct ASSET_GEOMETORY_PARAM_ST {
919915
}; // namespace paramdef
920916
}; // namespace from
921917

922-
static_assert(sizeof(from::paramdef::ASSET_GEOMETORY_PARAM_ST) == 352,
918+
static_assert(sizeof(from::paramdef::ASSET_GEOMETORY_PARAM_ST) == 320,
923919
"ASSET_GEOMETORY_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/ATK_PARAM_ST.hpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -1467,8 +1467,6 @@ struct ATK_PARAM_ST {
14671467
*/
14681468
int finalDamageRateId{ 0 };
14691469

1470-
unsigned char pad7_old[12];
1471-
14721470
/**
14731471
* @brief subCategory3
14741472
*/
@@ -1485,5 +1483,5 @@ struct ATK_PARAM_ST {
14851483
}; // namespace paramdef
14861484
}; // namespace from
14871485

1488-
static_assert(sizeof(from::paramdef::ATK_PARAM_ST) == 468,
1486+
static_assert(sizeof(from::paramdef::ATK_PARAM_ST) == 456,
14891487
"ATK_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/BONFIRE_WARP_PARAM_ST.hpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,6 @@ struct BONFIRE_WARP_PARAM_ST {
108108
*/
109109
bool dispMask01 : 1 { false };
110110

111-
unsigned char pad1_old : 6;
112-
113111
/**
114112
* @brief dispMask02
115113
*/
@@ -539,5 +537,5 @@ struct BONFIRE_WARP_PARAM_ST {
539537
}; // namespace paramdef
540538
}; // namespace from
541539

542-
static_assert(sizeof(from::paramdef::BONFIRE_WARP_PARAM_ST) == 240,
540+
static_assert(sizeof(from::paramdef::BONFIRE_WARP_PARAM_ST) == 236,
543541
"BONFIRE_WARP_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/BUDDY_PARAM_ST.hpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,6 @@ struct BUDDY_PARAM_ST {
187187
*/
188188
int generateAnimId{ -1 };
189189

190-
unsigned char Reserve2[4];
191-
192190
unsigned int unknown_0x5c{ 0 };
193191

194192
unsigned int unknown_0x60{ 0 };
@@ -227,5 +225,5 @@ struct BUDDY_PARAM_ST {
227225
}; // namespace paramdef
228226
}; // namespace from
229227

230-
static_assert(sizeof(from::paramdef::BUDDY_PARAM_ST) == 164,
228+
static_assert(sizeof(from::paramdef::BUDDY_PARAM_ST) == 160,
231229
"BUDDY_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/BULLET_PARAM_ST.hpp

+1-5
Original file line numberDiff line numberDiff line change
@@ -389,8 +389,6 @@ struct BULLET_PARAM_ST {
389389
*/
390390
bool isPenetrateObj : 1 { false };
391391

392-
unsigned char pad_old : 6;
393-
394392
unsigned char unknown_0x98_3 : 1 { 0 };
395393

396394
unsigned char pad : 5;
@@ -673,8 +671,6 @@ struct BULLET_PARAM_ST {
673671
*/
674672
bool isUseBulletWallFilter : 1 { false };
675673

676-
unsigned char pad1 : 1;
677-
678674
unsigned char unknown_0xc3_5 : 1 { 0 };
679675

680676
/**
@@ -845,5 +841,5 @@ struct BULLET_PARAM_ST {
845841
}; // namespace paramdef
846842
}; // namespace from
847843

848-
static_assert(sizeof(from::paramdef::BULLET_PARAM_ST) == 280,
844+
static_assert(sizeof(from::paramdef::BULLET_PARAM_ST) == 272,
849845
"BULLET_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/CHARACTER_INIT_PARAM.hpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,6 @@ struct CHARACTER_INIT_PARAM {
149149
*/
150150
int equip_Accessory04{ -1 };
151151

152-
unsigned char pad8_old[4];
153-
154152
unsigned char unknown_0x50 { 0 };
155153

156154
unsigned char unknown_0x51 { 0 };
@@ -761,5 +759,5 @@ struct CHARACTER_INIT_PARAM {
761759
}; // namespace paramdef
762760
}; // namespace from
763761

764-
static_assert(sizeof(from::paramdef::CHARACTER_INIT_PARAM) == 324,
762+
static_assert(sizeof(from::paramdef::CHARACTER_INIT_PARAM) == 320,
765763
"CHARACTER_INIT_PARAM paramdef size does not match detected size");

include/param/paramdef/CS_GRAPHICS_CONFIG_PARAM_ST.hpp

+1-6
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,6 @@ struct CS_GRAPHICS_CONFIG_PARAM_ST {
9999
*/
100100
unsigned char m_volumetricEffectQuality{ 3 };
101101

102-
/**
103-
* @brief m_dummy
104-
*/
105-
unsigned char m_dummy_0[3];
106-
107102
/**
108103
* @brief m_RayTracingQuality
109104
*/
@@ -118,5 +113,5 @@ struct CS_GRAPHICS_CONFIG_PARAM_ST {
118113
}; // namespace paramdef
119114
}; // namespace from
120115

121-
static_assert(sizeof(from::paramdef::CS_GRAPHICS_CONFIG_PARAM_ST) == 19,
116+
static_assert(sizeof(from::paramdef::CS_GRAPHICS_CONFIG_PARAM_ST) == 16,
122117
"CS_GRAPHICS_CONFIG_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/CUTSCENE_MAP_ID_PARAM_ST.hpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@ struct CUTSCENE_MAP_ID_PARAM_ST {
7777
*/
7878
int RefCamPosHitPartsID{ -1 };
7979

80-
unsigned char reserved_2_old[12];
81-
8280
int unknown_0x18{ 0 };
8381

8482
unsigned char reserved_2[8];
@@ -110,5 +108,5 @@ struct CUTSCENE_MAP_ID_PARAM_ST {
110108
}; // namespace paramdef
111109
}; // namespace from
112110

113-
static_assert(sizeof(from::paramdef::CUTSCENE_MAP_ID_PARAM_ST) == 60,
111+
static_assert(sizeof(from::paramdef::CUTSCENE_MAP_ID_PARAM_ST) == 48,
114112
"CUTSCENE_MAP_ID_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/EQUIP_PARAM_GEM_ST.hpp

+1-7
Original file line numberDiff line numberDiff line change
@@ -342,8 +342,6 @@ struct EQUIP_PARAM_GEM_ST {
342342
*/
343343
unsigned char defaultWepAttr{ 0 };
344344

345-
unsigned char pad2_old[2];
346-
347345
/**
348346
* @brief isSpecialSwordArt
349347
*/
@@ -604,8 +602,6 @@ struct EQUIP_PARAM_GEM_ST {
604602
*/
605603
bool canMountWep_Torch : 1 { false };
606604

607-
unsigned char reserved_canMountWep : 4;
608-
609605
/**
610606
* @brief canMountWep_HandToHand
611607
*/
@@ -626,8 +622,6 @@ struct EQUIP_PARAM_GEM_ST {
626622
*/
627623
unsigned char canMountWep_ThrowingWeapon : 1 { 0 };
628624

629-
unsigned char reserved2_canMountWep_old[3];
630-
631625
/**
632626
* @brief canMountWep_ReverseHandSword
633627
*/
@@ -703,5 +697,5 @@ struct EQUIP_PARAM_GEM_ST {
703697
}; // namespace paramdef
704698
}; // namespace from
705699

706-
static_assert(sizeof(from::paramdef::EQUIP_PARAM_GEM_ST) == 104,
700+
static_assert(sizeof(from::paramdef::EQUIP_PARAM_GEM_ST) == 96,
707701
"EQUIP_PARAM_GEM_ST paramdef size does not match detected size");

include/param/paramdef/EQUIP_PARAM_GOODS_ST.hpp

+1-5
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,6 @@ struct EQUIP_PARAM_GOODS_ST {
183183
*/
184184
unsigned char spEffectCategory{ 0 };
185185

186-
unsigned char pad3[1];
187-
188186
unsigned char unknown_0x40{ 0 };
189187

190188
/**
@@ -573,8 +571,6 @@ struct EQUIP_PARAM_GOODS_ST {
573571
*/
574572
bool isUseNoAttackRegion : 1 { true };
575573

576-
unsigned char pad1_old : 7;
577-
578574
unsigned char unknown_0x73_1 : 1 { 0 };
579575

580576
unsigned char unknown_0x73_2 : 1 { 0 };
@@ -739,5 +735,5 @@ struct EQUIP_PARAM_GOODS_ST {
739735
}; // namespace paramdef
740736
}; // namespace from
741737

742-
static_assert(sizeof(from::paramdef::EQUIP_PARAM_GOODS_ST) == 184,
738+
static_assert(sizeof(from::paramdef::EQUIP_PARAM_GOODS_ST) == 176,
743739
"EQUIP_PARAM_GOODS_ST paramdef size does not match detected size");

include/param/paramdef/EQUIP_PARAM_WEAPON_ST.hpp

+1-5
Original file line numberDiff line numberDiff line change
@@ -1186,8 +1186,6 @@ struct EQUIP_PARAM_WEAPON_ST {
11861186
*/
11871187
bool invisibleOnRemo : 1 { false };
11881188

1189-
unsigned char unk1: 3;
1190-
11911189
unsigned char unknown_0x17c_5: 1 { 0 };
11921190

11931191
unsigned char unknown_0x17c_6: 1 { 0 };
@@ -1879,8 +1877,6 @@ struct EQUIP_PARAM_WEAPON_ST {
18791877
*/
18801878
float vsPlayerDmgCorrectRate_Curse{ 1.f };
18811879

1882-
unsigned char pad_old[8];
1883-
18841880
/**
18851881
* @brief restrictSpecialSwordArt
18861882
*/
@@ -1892,5 +1888,5 @@ struct EQUIP_PARAM_WEAPON_ST {
18921888
}; // namespace paramdef
18931889
}; // namespace from
18941890

1895-
static_assert(sizeof(from::paramdef::EQUIP_PARAM_WEAPON_ST) == 676,
1891+
static_assert(sizeof(from::paramdef::EQUIP_PARAM_WEAPON_ST) == 664,
18961892
"EQUIP_PARAM_WEAPON_ST paramdef size does not match detected size");

include/param/paramdef/GAME_SYSTEM_COMMON_PARAM_ST.hpp

+1-9
Original file line numberDiff line numberDiff line change
@@ -1310,8 +1310,6 @@ struct GAME_SYSTEM_COMMON_PARAM_ST {
13101310
*/
13111311
float aiSightRate_midnightA{ 1.f };
13121312

1313-
unsigned char reserve4_2[4];
1314-
13151313
int unknown_0x230 { 0 };
13161314

13171315
/**
@@ -1994,10 +1992,6 @@ struct GAME_SYSTEM_COMMON_PARAM_ST {
19941992
*/
19951993
float bonfireCheckEnemyRange{ -1.f };
19961994

1997-
unsigned char reserved_124_0[48];
1998-
1999-
unsigned char reserved_124_1[32];
2000-
20011995
int unknown_0x2f0{ 0 };
20021996

20031997
int unknown_0x2f4{ 0 };
@@ -2042,8 +2036,6 @@ struct GAME_SYSTEM_COMMON_PARAM_ST {
20422036

20432037
float unknown_0x344{ 0.0f };
20442038

2045-
unsigned char pad_0x348[40];
2046-
20472039
int unknown_0x34c{ 0 };
20482040

20492041
int unknown_0x350{ 0 };
@@ -2091,5 +2083,5 @@ struct GAME_SYSTEM_COMMON_PARAM_ST {
20912083
}; // namespace paramdef
20922084
}; // namespace from
20932085

2094-
static_assert(sizeof(from::paramdef::GAME_SYSTEM_COMMON_PARAM_ST) == 1148,
2086+
static_assert(sizeof(from::paramdef::GAME_SYSTEM_COMMON_PARAM_ST) == 1024,
20952087
"GAME_SYSTEM_COMMON_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/NETWORK_MSG_PARAM_ST.hpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,6 @@ struct NETWORK_MSG_PARAM_ST {
220220
*/
221221
int forceJoinBlack_C_Npc{ -1 };
222222

223-
unsigned char pad2[28];
224-
225223
int unknown_0xa4{ 0 };
226224

227225
int unknown_0xa8{ 0 };
@@ -238,5 +236,5 @@ struct NETWORK_MSG_PARAM_ST {
238236
}; // namespace paramdef
239237
}; // namespace from
240238

241-
static_assert(sizeof(from::paramdef::NETWORK_MSG_PARAM_ST) == 220,
239+
static_assert(sizeof(from::paramdef::NETWORK_MSG_PARAM_ST) == 192,
242240
"NETWORK_MSG_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/NETWORK_PARAM_ST.hpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,6 @@ struct NETWORK_PARAM_ST {
174174
*/
175175
float breakInRequestTimeOutSec{ 20.f };
176176

177-
unsigned char pad_1_old[4];
178-
179177
unsigned char unknown_0x7c{ 0 };
180178

181179
unsigned char pad_1[3];
@@ -880,5 +878,5 @@ struct NETWORK_PARAM_ST {
880878
}; // namespace paramdef
881879
}; // namespace from
882880

883-
static_assert(sizeof(from::paramdef::NETWORK_PARAM_ST) == 636,
881+
static_assert(sizeof(from::paramdef::NETWORK_PARAM_ST) == 632,
884882
"NETWORK_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/NPC_PARAM_ST.hpp

+1-7
Original file line numberDiff line numberDiff line change
@@ -1654,8 +1654,6 @@ struct NPC_PARAM_ST {
16541654
*/
16551655
signed char freezeGuardResist{ 0 };
16561656

1657-
unsigned char pad1[1];
1658-
16591657
unsigned char unknown_0x1e3{ 0 };
16601658

16611659
/**
@@ -1998,8 +1996,6 @@ struct NPC_PARAM_ST {
19981996
*/
19991997
unsigned char chrNavimeshFlag_Dead{ 0 };
20001998

2001-
unsigned char pad7[1];
2002-
20031999
/**
20042000
* @brief isConsideredUndead
20052001
*/
@@ -2212,8 +2208,6 @@ struct NPC_PARAM_ST {
22122208
*/
22132209
float lockScoreOffset{ 0.f };
22142210

2215-
unsigned char pad12_old[8];
2216-
22172211
/**
22182212
* @brief dlcGameClearSpEffectID
22192213
*/
@@ -2225,5 +2219,5 @@ struct NPC_PARAM_ST {
22252219
}; // namespace paramdef
22262220
}; // namespace from
22272221

2228-
static_assert(sizeof(from::paramdef::NPC_PARAM_ST) == 752,
2222+
static_assert(sizeof(from::paramdef::NPC_PARAM_ST) == 736,
22292223
"NPC_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/OBJ_ACT_PARAM_ST.hpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,6 @@ struct OBJ_ACT_PARAM_ST {
161161
*/
162162
int preActionSfxId{ -1 };
163163

164-
unsigned char pad2_old[40];
165-
166164
unsigned char unknown_0x38{ 0 };
167165

168166
unsigned char unknown_0x3c{ 0 };
@@ -181,5 +179,5 @@ struct OBJ_ACT_PARAM_ST {
181179
}; // namespace paramdef
182180
}; // namespace from
183181

184-
static_assert(sizeof(from::paramdef::OBJ_ACT_PARAM_ST) == 136,
182+
static_assert(sizeof(from::paramdef::OBJ_ACT_PARAM_ST) == 96,
185183
"OBJ_ACT_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/PLAYER_COMMON_PARAM_ST.hpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -374,8 +374,6 @@ struct PLAYER_COMMON_PARAM_ST {
374374
*/
375375
int resistCurseItemLotParamId_map{ -1 };
376376

377-
unsigned char reserved41_old[52];
378-
379377
int unknown_0xcc{ 0 };
380378

381379
int unknown_0xd0{ 0 };
@@ -394,5 +392,5 @@ struct PLAYER_COMMON_PARAM_ST {
394392
}; // namespace paramdef
395393
}; // namespace from
396394

397-
static_assert(sizeof(from::paramdef::PLAYER_COMMON_PARAM_ST) == 308,
395+
static_assert(sizeof(from::paramdef::PLAYER_COMMON_PARAM_ST) == 256,
398396
"PLAYER_COMMON_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/PLAY_REGION_PARAM_ST.hpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,6 @@ struct PLAY_REGION_PARAM_ST {
265265
*/
266266
bool isAutoIntrudePoint : 1 { false };
267267

268-
unsigned char pad1_old: 7;
269-
270268
unsigned char unknown_0x45_1: 1 { 0 };
271269

272270
unsigned char pad1: 6;
@@ -603,5 +601,5 @@ struct PLAY_REGION_PARAM_ST {
603601
}; // namespace paramdef
604602
}; // namespace from
605603

606-
static_assert(sizeof(from::paramdef::PLAY_REGION_PARAM_ST) == 276,
604+
static_assert(sizeof(from::paramdef::PLAY_REGION_PARAM_ST) == 272,
607605
"PLAY_REGION_PARAM_ST paramdef size does not match detected size");

include/param/paramdef/POSTURE_CONTROL_PARAM_WEP_RIGHT_ST.hpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -278,8 +278,6 @@ struct POSTURE_CONTROL_PARAM_WEP_RIGHT_ST {
278278
*/
279279
short a016_leftWristIO{ 0 };
280280

281-
unsigned char pad[4];
282-
283281
int unknown_0x6c{ 0 };
284282

285283
int unknown_0x70{ 0 };
@@ -305,6 +303,6 @@ struct POSTURE_CONTROL_PARAM_WEP_RIGHT_ST {
305303
}; // namespace paramdef
306304
}; // namespace from
307305

308-
static_assert(sizeof(from::paramdef::POSTURE_CONTROL_PARAM_WEP_RIGHT_ST) == 148,
306+
static_assert(sizeof(from::paramdef::POSTURE_CONTROL_PARAM_WEP_RIGHT_ST) == 144,
309307
"POSTURE_CONTROL_PARAM_WEP_RIGHT_ST paramdef size does not match detected "
310308
"size");

0 commit comments

Comments
 (0)