Skip to content

Commit 0a5c31d

Browse files
authored
fix: add built-in titles for the activityBar items (#424)
* fix: add menu.account source key * fix(activitybar): add title for the built-in bars * test: update the Workbench snapshot
1 parent 2ccc92f commit 0a5c31d

File tree

5 files changed

+8
-3
lines changed

5 files changed

+8
-3
lines changed

src/i18n/source/zh-CN.json

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"menubar": "菜单栏",
77
"menu.file": "文件",
88
"menu.settings": "设置",
9+
"menu.account": "账号",
910
"menu.colorTheme": "颜色主题",
1011
"menu.newFile": "新建文件",
1112
"menu.newFolder": "新建文件夹",

src/model/workbench/activityBar.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,14 @@ export function builtInActivityBar(): IActivityBar {
5454
{
5555
id: ACTIVITY_BAR_GLOBAL_ACCOUNT,
5656
name: localize('menu.account', 'Account'),
57+
title: localize('menu.account', 'Account'),
5758
icon: 'account',
5859
type: 'global',
5960
},
6061
{
6162
id: ACTIVITY_BAR_GLOBAL_SETTINGS,
62-
name: localize('menu.colorTheme', 'Color Theme'),
63+
name: localize('menu.settings', 'Settings'),
64+
title: localize('menu.settings', 'Settings'),
6365
icon: 'settings-gear',
6466
type: 'global',
6567
contextMenu: [

src/model/workbench/explorer/explorer.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ export function builtInExplorerActivityItem() {
6060
id: EXPLORER_ACTIVITY_ITEM,
6161
name: localize(EXPLORER_ACTIVITY_ITEM, 'Explore'),
6262
icon: 'files',
63+
title: localize(EXPLORER_ACTIVITY_ITEM, 'Explore'),
6364
};
6465
}
6566

src/model/workbench/search.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ export function builtInSearchActivityItem() {
4141
return {
4242
id: SEARCH_ACTIVITY_ITEM,
4343
name: localize(SEARCH_ACTIVITY_ITEM, 'Search'),
44+
title: localize(SEARCH_ACTIVITY_ITEM, 'Search'),
4445
icon: 'search',
4546
};
4647
}

src/workbench/__tests__/__snapshots__/workbench.test.tsx.snap

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ exports[`Test Workbench Component Match The WorkbenchView snapshot 1`] = `
4141
>
4242
<span
4343
class="mo-activityBar__label codicon codicon-files"
44-
title=""
44+
title="浏览"
4545
/>
4646
<div
4747
class="mo-activityBar__indicator"
@@ -53,7 +53,7 @@ exports[`Test Workbench Component Match The WorkbenchView snapshot 1`] = `
5353
>
5454
<span
5555
class="mo-activityBar__label codicon codicon-search"
56-
title=""
56+
title="搜索"
5757
/>
5858
</li>
5959
</ul>

0 commit comments

Comments
 (0)