-
Notifications
You must be signed in to change notification settings - Fork 57
Feature: Add a scalar and vector data field to VTK write test [2/3] #1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Note: even though writing of ghosts was set true (and not changed by this commit), the ghost elements do not seem to be written, which is odd. |
Could be resolved, the forest in the example was build without a ghost layer. |
…iter' into feature-extend_vtk_test_with_data
The tests fail in VTK API mode due to a ghost tree being requested by grid_element_shape and the function expecting only local trees. |
take num_ghosts into account, too
Co-authored-by: David Knapp <david.knapp@dlr.de>
…a' into feature-extend_vtk_test_with_data
This currently fails due ghost trees not being considered in grid_element_shape<t8_forest_t> (const t8_forest_t grid, const t8_locidx_t itree, const t8_element_t *element)
{
const t8_eclass_t eclass = t8_forest_get_eclass (grid, itree); Fix is easy, extend the function to accept ghost tree ids and call "get_ghost_tree_class" if so. Edit: These were already adressed by @Davknapp and should be merged now. |
9b7c069
to
4006086
Compare
…_vtk_test_with_data
71db8ef
to
59efd26
Compare
Feature: Add a scalar and vector data field to VTK write test [2/3]
Closes #1629
Describe your changes here:
The first step towards #1487.
The vtk_writer example did not write any user data.
Extended the example with 2 data fields, one scalar, one vector and dummy data.
The data fields do already contain values for the ghost elements.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:
,Bugfix:
,Feature:
,Improvement:
orOther:
.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.Tag Label
License
doc/
(or already has one).