Errors in current state of pre-commit script #1534
Labels
Bug
For a bug in the Code
priority:high
Should be solved as soon as possible
Wiki
workload:low
Would take half a day or less
Bug report
Describe the bug
While working in t8code, I today realized two things regarding the
pre-commit
script:Since I copied the
pre-commit
script into.git/hooks
as described in the Coding Guidelines, the names of the scripts for checking macros and indentation had changed. As a result, mypre-commit
hook did not find them and thus always reported every file as not indented.My suggestion to fix this would be to change the coding guidelines, such that it suggests linking the script from
scripts/pre-commit
into.git/hooks/
rather than copying it. This way, any changes in thepre-commit
script would automatically be applied within the hook. (This does require a minor update of how to handle the paths, as you will see in the associated PR.)After figuring out the issue described in 1., I switched to the latest state of the
pre-commit
script and found some errors there. My guess is that some local changes have accidentially been pushed to origin, because of:My suggestion to fix this will be outlined in a PR I will open next, that is, Bugfix: Fix wrong paths in pre-commit script #1535.
To Reproduce
Feel free to try the current version of
pre-commit
for yourselfExpected behavior
Log files
Environment (please complete the following information):
Estimated priority
"Priority: high" Should be solved as soon as possible
Additional context
The text was updated successfully, but these errors were encountered: