Clippy #102
Merged
Clippy #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I understand it, we get warns for dead code because we're _only_ using the fields here via their Debug-instances (eg. for logs) Since we're actually just-fine-thank-you-very-much with the autogenerated strings, this seems needlessly strict to us and creating custom Display-instances just to squelch this seems even noisier than allowing the dead_code fields.
|
Need help with the remaining failures (run |
cafkafk
requested changes
Jan 30, 2025
|
I wasn't sure how to best show solving the last clippy lints without having something to point at so I made a commit 0f9367c and added some GitHub comments. I hope that's somewhat useful. It did get hit with a rust fmt which makes the diff unnecessarily large, but I've pointed at the parts of the code that were changed, and tried to show why clippy didn't give great hints (clippy didn't fully know to explain what the changes meant for the impl's using the trait) |
|
Thanks for the help, think I've incorporated it all (and dropped the formatting for now so we don't mix that up in this already-large diff) |
cafkafk
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few clippy hints remain that I don't know how to deal with, need a hand