Prospector compliance #2

Author: Alexis

oxe-api/resource/form/extract_form.py

@@ -66,7 +66,7 @@ def get(self, **kwargs):
             .filter(self.db.tables["FormAnswer"].form_question_id.in_([q.id for q in questions])) \
             .all()
 
-        user_ids = list(set([a.user_id for a in answers]))
+        user_ids = list({a.user_id for a in answers})
 
         users = self.db.session \
             .query(self.db.tables["User"]) \
@@ -116,7 +116,7 @@ def prepare_xlsx(self, df, questions, users):
         # Clean cells
 
         for c in df.columns:
-            df[c] = df[c].apply(lambda x: clean_html(x))
+            df[c] = df[c].apply(clean_html)
 
         # Build the XLS file
 

oxe-api/utils/speadsheet.py

@@ -2,7 +2,7 @@
 
 
 def clean_html(raw_html):
-    if type(raw_html) is not str:
+    if not isinstance(raw_html, str):
         return None
 
     raw_html = raw_html.replace("</p>", "\n").replace("&nbsp;", "")

oxe-api/wsgi.py

@@ -6,4 +6,4 @@
 
 # pylint: disable=wrong-import-position
 from app import app as application
-assert app  # nosec
+assert application  # nosec