From 9227f4e359eeea1d47e4a1f06096764b9e8a5ea6 Mon Sep 17 00:00:00 2001 From: Yeganathan S Date: Tue, 3 Oct 2023 22:54:57 +0530 Subject: [PATCH] Update Feature Flags for new plans --- .../conversationSettingsUpdate.ts | 4 +- backend/src/bin/scripts/unleash-init.ts | 45 ------------------- backend/src/feature-flags/isFeatureEnabled.ts | 10 ++--- backend/src/types/common.ts | 1 - 4 files changed, 5 insertions(+), 55 deletions(-) diff --git a/backend/src/api/conversation/conversationSettingsUpdate.ts b/backend/src/api/conversation/conversationSettingsUpdate.ts index da99b53bb4..0c9072d246 100644 --- a/backend/src/api/conversation/conversationSettingsUpdate.ts +++ b/backend/src/api/conversation/conversationSettingsUpdate.ts @@ -1,14 +1,12 @@ import Error403 from '../../errors/Error403' -import isFeatureEnabled from '../../feature-flags/isFeatureEnabled' import Permissions from '../../security/permissions' import ConversationService from '../../services/conversationService' import PermissionChecker from '../../services/user/permissionChecker' -import { FeatureFlag } from '../../types/common' export default async (req, res) => { new PermissionChecker(req).validateHas(Permissions.values.conversationEdit) - if (req.body.customUrl && !(await isFeatureEnabled(FeatureFlag.COMMUNITY_HELP_CENTER_PRO, req))) { + if (req.body.customUrl) { await req.responseHandler.error( req, res, diff --git a/backend/src/bin/scripts/unleash-init.ts b/backend/src/bin/scripts/unleash-init.ts index 9cc85d3397..61af560df7 100644 --- a/backend/src/bin/scripts/unleash-init.ts +++ b/backend/src/bin/scripts/unleash-init.ts @@ -65,17 +65,6 @@ const constaintConfiguration = { }, ], ], - [FeatureFlag.COMMUNITY_HELP_CENTER_PRO]: [ - [ - { - values: [Plans.values.growth], - inverted: false, - operator: 'IN', - contextName: 'plan', - caseInsensitive: false, - }, - ], - ], [FeatureFlag.CSV_EXPORT]: [ [ { @@ -197,23 +186,6 @@ const constaintConfiguration = { caseInsensitive: false, }, ], - [ - { - values: [Plans.values.essential], - inverted: false, - operator: 'IN', - contextName: 'plan', - caseInsensitive: false, - }, - { - value: PLAN_LIMITS[Plans.values.essential][FeatureFlag.MEMBER_ENRICHMENT].toString(), - values: [], - inverted: false, - operator: 'NUM_LT', - contextName: 'memberEnrichmentCount', - caseInsensitive: false, - }, - ], ], [FeatureFlag.ORGANIZATION_ENRICHMENT]: [ [ @@ -250,23 +222,6 @@ const constaintConfiguration = { caseInsensitive: false, }, ], - [ - { - values: [Plans.values.essential], - inverted: false, - operator: 'IN', - contextName: 'plan', - caseInsensitive: false, - }, - { - value: PLAN_LIMITS[Plans.values.essential][FeatureFlag.ORGANIZATION_ENRICHMENT].toString(), - values: [], - inverted: false, - operator: 'NUM_LT', - contextName: 'organizationEnrichmentCount', - caseInsensitive: false, - }, - ], ], [FeatureFlag.SEGMENTS]: [], } diff --git a/backend/src/feature-flags/isFeatureEnabled.ts b/backend/src/feature-flags/isFeatureEnabled.ts index 9fc88d2f36..7b076161c3 100644 --- a/backend/src/feature-flags/isFeatureEnabled.ts +++ b/backend/src/feature-flags/isFeatureEnabled.ts @@ -9,8 +9,6 @@ export const PLAN_LIMITS = { [Plans.values.essential]: { [FeatureFlag.AUTOMATIONS]: 2, [FeatureFlag.CSV_EXPORT]: 2, - [FeatureFlag.MEMBER_ENRICHMENT]: 5, - [FeatureFlag.ORGANIZATION_ENRICHMENT]: 5, }, [Plans.values.growth]: { [FeatureFlag.AUTOMATIONS]: 10, @@ -19,10 +17,10 @@ export const PLAN_LIMITS = { [FeatureFlag.ORGANIZATION_ENRICHMENT]: 200, }, [Plans.values.scale]: { - [FeatureFlag.AUTOMATIONS]: 100, - [FeatureFlag.CSV_EXPORT]: 100, - [FeatureFlag.MEMBER_ENRICHMENT]: 10000, - [FeatureFlag.ORGANIZATION_ENRICHMENT]: 2000, + [FeatureFlag.AUTOMATIONS]: 20, + [FeatureFlag.CSV_EXPORT]: 20, + [FeatureFlag.MEMBER_ENRICHMENT]: Infinity, + [FeatureFlag.ORGANIZATION_ENRICHMENT]: Infinity, }, [Plans.values.enterprise]: { [FeatureFlag.AUTOMATIONS]: Infinity, diff --git a/backend/src/types/common.ts b/backend/src/types/common.ts index 3c8153b7a2..0697215b1e 100644 --- a/backend/src/types/common.ts +++ b/backend/src/types/common.ts @@ -19,7 +19,6 @@ export interface SearchCriteria { export enum FeatureFlag { AUTOMATIONS = 'automations', - COMMUNITY_HELP_CENTER_PRO = 'community-help-center-pro', EAGLE_EYE = 'eagle-eye', CSV_EXPORT = 'csv-export', LINKEDIN = 'linkedin',