Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

Note that Rust stable supports WASI as of 1.35 #3

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

callahad
Copy link
Contributor

@callahad callahad commented Jun 4, 2019

Unless there's a compelling reason to force people into nightly builds, we should probably call attention to WASI support in stable Rust.

@tschneidereit
Copy link
Member

Ooh, good call—thank you!

@tschneidereit tschneidereit merged commit 6c1ce87 into CraneStation:master Jun 4, 2019
@callahad
Copy link
Contributor Author

callahad commented Jun 4, 2019

Spotted similar references in a few other CraneStation/ repos. I'll get those updated in just a sec :)

@sunfishcode
Copy link
Member

I would prefer not to drag people through the triple changing again or explain the target macros changing and they have to write #[cfg(any(target_env = "wasi", target_os = "wasi"))] if they don't want their code to break in a future Rust release. Also, rust-lang/rust#59727 is important. In all, my recommendation would be to leave the instructions pointed at nightly Rust for now.

@tschneidereit
Copy link
Member

That's a good point. In particular the target triple. However, ideally we'd support the -unknown part as optional. It's my understanding that that's how target triples are meant to be interpreted to begin with?

@callahad
Copy link
Contributor Author

callahad commented Jun 4, 2019

@sunfishcode All three of those pull requests are currently in the Rust beta branch... would it be fair to point people to that (and thus to Stable, once 1.36 gets released), or are you still concerned about other outstanding issues that need to shake out?

@sunfishcode
Copy link
Member

Triples in general have flexibility here, but the Rust targeting system requires an exact match, so the -unknown isn't optional in rustc. It's currently required on stable and not accepted on beta.

The PRs I linked to are the important ones, so if those are on beta, then that sounds fine.

Of course, WASI itself is still wasi_unstable. It's relatively stable at this point, but it's important people know that this is just the beginning :-).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants