Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to specify Hikari configuration file for pruning connection #661

Closed
usmansaleem opened this issue Oct 27, 2022 · 0 comments · Fixed by #663
Closed

Option to specify Hikari configuration file for pruning connection #661

usmansaleem opened this issue Oct 27, 2022 · 0 comments · Fixed by #663
Assignees
@usmansaleem
Labels
support TeamCerberus Under active development by TeamCerberus @Consensys

Comments

@usmansaleem
Copy link
Collaborator

usmansaleem commented Oct 27, 2022 •
edited
Loading

Provide option to specify Hikari configuration file for pruning connection.

--slashing-protection-pruning-db-pool-configuration-file

Before this change, both pruning and slashing protection database connections used same configuration file. Specifying separate configuration file can allow to fine-tune Hikari/Postgresql driver properties such as timeouts etc. specific to pruning connection.

The cli options works exactly as https://docs.web3signer.consensys.net/en/latest/Reference/CLI/CLI-Subcommands/#slashing-protection-db-pool-configuration-file .
@usmansaleem usmansaleem added the TeamCerberus Under active development by TeamCerberus @Consensys label Oct 27, 2022
@usmansaleem usmansaleem self-assigned this Oct 27, 2022
@usmansaleem usmansaleem mentioned this issue Oct 27, 2022
Merged
2 tasks
@usmansaleem usmansaleem added the doc-change-required Indicates an issue or PR that requires doc to be updated label Oct 31, 2022
@alexandratran alexandratran mentioned this issue Nov 8, 2022
Closed
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 8, 2022
@iamhsk iamhsk added the support label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usmansaleem usmansaleem

Labels
support TeamCerberus Under active development by TeamCerberus @Consensys
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cli option to specify Hikari configuration for pruning db connection usmansaleem/web3signer
3 participants
@usmansaleem @iamhsk @alexandratran