Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pedersen verification key reference field #1295

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Oct 8, 2024

Description

To update changes incorporated in Consensys/gnark-crypto#548.

TODO! update gnark-crypto dependency in this PR to master after gnark-crypto PR is merged so that we have good reference point (not to a tangling commit in a PR).

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

ivokub added 6 commits October 8, 2024 23:01
As we update gnark-crypto dependency then we code generate a bit more
code for the tinyfield package. This is unrelated change, but needs to
be included for CI to pass.
@ivokub ivokub added the cleanup label Oct 8, 2024
@ivokub ivokub requested a review from Tabaie October 8, 2024 23:14
@ivokub ivokub self-assigned this Oct 8, 2024
@Tabaie Tabaie merged commit af754dd into master Oct 10, 2024
5 checks passed
@Tabaie Tabaie deleted the chore/pedersen-vk-gsigmaneg branch October 10, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants