fix: shift constraint indices by nb of public vars #1128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When extracting the constraint indices for range checking, we didn't take into account the added constraints rows in the traces which account for the public inputs. We now shift the constraint indices by the number of public variables.
Type of change
How has this been tested?
In zkevm repo.
How has this been benchmarked?
Not benchmarked. But added an optimization to break the loop early when all results have been found.
Checklist:
golangci-lint
does not output errors locally