Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shift constraint indices by nb of public vars #1128

Merged
merged 2 commits into from
May 14, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented May 9, 2024

Description

When extracting the constraint indices for range checking, we didn't take into account the added constraints rows in the traces which account for the public inputs. We now shift the constraint indices by the number of public variables.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

In zkevm repo.

How has this been benchmarked?

Not benchmarked. But added an optimization to break the loop early when all results have been found.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added bug Something isn't working zk-evm P1: High Issue priority: high labels May 9, 2024
@ivokub ivokub requested a review from gbotrel May 9, 2024 09:04
@ivokub ivokub self-assigned this May 9, 2024
@ivokub ivokub merged commit e822c15 into master May 14, 2024
7 checks passed
@ivokub ivokub deleted the fix/extrangecheck-pubshift branch May 14, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1: High Issue priority: high zk-evm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants