feat: stabilize anonymous hint function names #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbotrel
approved these changes
Feb 13, 2024
ahmetyalp
pushed a commit
to ahmetyalp/gnark
that referenced
this pull request
Feb 14, 2024
* test: add regression test for anonymous function names * feat: implement new-to-old style regexp * feat: map anonymous function names * fixup! feat: implement new-to-old style regexp * docs: add method documentation * test: add regression test for compiled circuit * refactor: lessen double register log severity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements conversion from new-style anonymous function names to old-style. The goal is to keep backwards compatibility with already compiled circuits.
Fixes #1045
Type of change
How has this been tested?
Checklist:
golangci-lintdoes not output errors locally