Experimental flag to disable parallel processing of keystore config files #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em property as an additional flag to override hashicorp processing in sequential for corner cases
jframe
reviewed
Jun 1, 2023
signing/src/main/java/tech/pegasys/web3signer/signing/config/SignerLoader.java
Outdated
Show resolved
Hide resolved
…ig files. Refactor SignerLoader and simplify SigningMetadata to ArtifactSigner conversion
jframe
reviewed
Jun 2, 2023
commandline/src/main/java/tech/pegasys/web3signer/commandline/Web3SignerBaseCommand.java
Outdated
Show resolved
Hide resolved
jframe
approved these changes
Jun 2, 2023
usmansaleem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Process metadata files in parallel. Use experimental flag
--Xmetadata-files-parallel-processing-enabledto disable parallel processing of keystore config files which would solve corner case of hashicorp with 30000+ connections.Fixed Issue(s)
fixes #786
fixes #736
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog