Proposal to fix LDAP crashes #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galenguyer
reviewed
Mar 18, 2022
| for err != nil { | ||
| if attempts < maxReconnectionAttempts { | ||
| c.app.db.AddLog(0, "ldap bind error: "+err.Error()) | ||
| log.Info(err) |
There was a problem hiding this comment.
Dunno if log has this but if there's a log.Error you should use that so error logs are printed to stderr
There was a problem hiding this comment.
oh, brain, I totally didn't bother to look this up at 3AM
|
I don't think this even fixed the issue. I saw it die again. Gonna have to look at the code again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening plug for the first time in a few hours, the app will sometimes fail to connect to LDAP, and the pod will crash. This will require the pod to wait a bit and attempt re-connection several times before doing so.
Closes #4